Skip to content

Commit

Permalink
[Dashboard] Fix help documentation link for dashboard (#143894)
Browse files Browse the repository at this point in the history
* Modify help link for dashboard

* Fix stub
  • Loading branch information
Heenawter authored Oct 25, 2022
1 parent aa97bff commit 94fe004
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,16 @@ import { pluginServices } from '../../services/plugin_services';
export function addHelpMenuToAppChrome() {
const {
chrome: { setHelpExtension },
documentationLinks: { kibanaGuideDocLink },
documentationLinks: { dashboardDocLink },
} = pluginServices.getServices();

setHelpExtension({
appName: i18n.translate('dashboard.helpMenu.appName', {
defaultMessage: 'Dashboards',
}),
links: [
{
linkType: 'documentation',
href: `${kibanaGuideDocLink}`,
href: `${dashboardDocLink}`,
},
],
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,6 @@ export const documentationLinksServiceFactory: DocumentationLinksServiceFactory
return {
indexPatternsDocLink: corePluginMock.docLinks.links.indexPatterns.introduction,
kibanaGuideDocLink: corePluginMock.docLinks.links.kibana.guide,
dashboardDocLink: corePluginMock.docLinks.links.dashboard.guide,
};
};
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,16 @@ export const documentationLinksServiceFactory: DocumentationLinksServiceFactory
const {
docLinks: {
links: {
kibana: { guide },
kibana,
indexPatterns: { introduction },
dashboard,
},
},
} = coreStart;

return {
indexPatternsDocLink: introduction,
kibanaGuideDocLink: guide,
kibanaGuideDocLink: kibana.guide,
dashboardDocLink: dashboard.guide,
};
};
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@ import { CoreStart } from '@kbn/core/public';
export interface DashboardDocumentationLinksService {
indexPatternsDocLink: CoreStart['docLinks']['links']['indexPatterns']['introduction'];
kibanaGuideDocLink: CoreStart['docLinks']['links']['kibana']['guide'];
dashboardDocLink: CoreStart['docLinks']['links']['dashboard']['guide'];
}

0 comments on commit 94fe004

Please sign in to comment.