Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens][Visualize] Adds option to disable cursor sync on dashboards #143355

Merged
merged 6 commits into from
Oct 17, 2022
Merged

[Lens][Visualize] Adds option to disable cursor sync on dashboards #143355

merged 6 commits into from
Oct 17, 2022

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Oct 14, 2022 •
edited
Loading

Summary

Closes #130636

It adds an extra switch to the dashboard options panel "Sync cursor across panels". For bwc this is by default on, but the user can now switch it off and disable the cursor synchronization across panels. In that case, the sync tooltips options is also disabled.

This can be a useful setting especially for dashboards with performance issues.

lens

Checklist

@github-actions
Copy link
Contributor

Documentation preview:

@stratoula stratoula changed the title [Lens][Visualize] Disable cursor sync on dashboard level option [Lens][Visualize] Add setting to disable cursor sync on dashboard level option Oct 14, 2022
@stratoula stratoula changed the title [Lens][Visualize] Add setting to disable cursor sync on dashboard level option [Lens][Visualize] Add setting to disable cursor sync on dashboards Oct 14, 2022
@stratoula stratoula changed the title [Lens][Visualize] Add setting to disable cursor sync on dashboards [Lens][Visualize] Adds setting to disable cursor sync on dashboards Oct 14, 2022
@stratoula stratoula changed the title [Lens][Visualize] Adds setting to disable cursor sync on dashboards [Lens][Visualize] Adds option to disable cursor sync on dashboards Oct 14, 2022
@stratoula stratoula added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Feature:Lens release_note:enhancement v8.6.0 backport:skip This commit does not require backporting Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 14, 2022
@stratoula stratoula marked this pull request as ready for review October 14, 2022 13:19
@stratoula stratoula requested review from a team as code owners October 14, 2022 13:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

jbudz
jbudz approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

limits.yml

@botelastic botelastic bot added Feature:Embedding Embedding content via iFrame Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) labels Oct 14, 2022
flash1293
flash1293 approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VisEditors changes LGTM, everything works as expected

@Heenawter Heenawter self-requested a review October 14, 2022 15:11
Heenawter
Heenawter approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally + code owners review - everything worked great! 🎉

Left one tiny design nit.

src/plugins/dashboard/public/application/top_nav/options.tsx Outdated
<EuiFormRow>
<EuiSwitch
label={i18n.translate('dashboard.topNav.options.syncTooltipsBetweenPanelsSwitchLabel', {
defaultMessage: 'Sync tooltips across panels',
})}
checked={this.state.syncTooltips}
disabled={!Boolean(this.state.syncCursor)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch! If your cursor isn't synced, doesn't make sense that the tooltip is synced 👍

src/plugins/dashboard/public/application/top_nav/options.tsx Outdated Show resolved Hide resolved
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
dashboard 113 114 +1
expressionHeatmap 102 103 +1
expressions 1729 1734 +5
expressionXY 148 149 +1
lens 567 568 +1
total +9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.0MB 1.0MB +27.0B
dashboard 422.3KB 423.3KB +943.0B
expressionHeatmap 91.3KB 91.3KB +26.0B
expressionXY 119.1KB 119.3KB +250.0B
lens 1.3MB 1.3MB +50.0B
visTypeTimelion 109.2KB 109.2KB +22.0B
visTypeTimeseries 503.2KB 503.3KB +76.0B
visualizations 268.0KB 268.2KB +187.0B
total +1.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 41.2KB 41.2KB +28.0B
embeddable 70.0KB 70.1KB +26.0B
expressionHeatmap 14.0KB 14.2KB +136.0B
expressions 97.4KB 97.6KB +214.0B
expressionXY 37.1KB 37.1KB +24.0B
visTypeTimelion 10.5KB 10.6KB +106.0B
visTypeTimeseries 19.5KB 19.6KB +110.0B
total +644.0B
Unknown metric groups

API count

id before after diff
dashboard 120 121 +1
expressionHeatmap 106 107 +1
expressions 2183 2191 +8
expressionXY 158 159 +1
lens 658 659 +1
total +12

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Dosant
Dosant approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syncCursor addition in embeddable lgtm (looks like follows existing syncColors and syncTooltips code)

@stratoula stratoula merged commit 46c1250 into elastic:main Oct 17, 2022
@drewdaemon drewdaemon mentioned this pull request Oct 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson left review comments

@Heenawter Heenawter Heenawter approved these changes

@Dosant Dosant Dosant approved these changes

@jbudz jbudz jbudz approved these changes

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Embedding Embedding content via iFrame Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Feature:Lens Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens][Visualize] Allow no cursor sync of the dashboard panels
8 participants
@stratoula @elasticmachine @kibana-ci @flash1293 @jbudz @Dosant @Heenawter @ThomThomson