Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data views] Add index pattern setter and getter and deprecate title field #142945

Merged
merged 8 commits into from
Oct 10, 2022

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Oct 9, 2022

Summary

Previously, data view names and their index pattern were one and the same. The data view index pattern field is named title which is now misleading. This PR provides getIndexPattern and setIndexPattern methods while deprecating the title attribute.

Closes: #135451

@mattkime mattkime changed the title add index pattern setter and getter and deprecate title field [data views] Add index pattern setter and getter and deprecate title field Oct 9, 2022
@mattkime mattkime marked this pull request as ready for review October 10, 2022 02:08
@mattkime mattkime requested a review from a team as a code owner October 10, 2022 02:08
@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:AppServicesSv v8.6.0 labels Oct 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@mattkime mattkime added the release_note:skip Skip the PR/issue when compiling release notes label Oct 10, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2513 2515 +2
dataViews 225 228 +3
total +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataViewEditor 31.2KB 31.2KB +47.0B
dataViewFieldEditor 154.4KB 154.4KB +48.0B
total +95.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataViews 44.7KB 44.8KB +177.0B
Unknown metric groups

API count

id before after diff
data 3221 3227 +6
dataViews 983 992 +9
total +15

References to deprecated APIs

id before after diff
aiops 0 20 +20
apm 29 34 +5
controls 0 15 +15
data 9 57 +48
dataViewEditor 0 5 +5
dataViewManagement 35 60 +25
dataViews 24 38 +14
dataVisualizer 3 23 +20
discover 18 53 +35
fleet 28 48 +20
graph 32 52 +20
infra 25 65 +40
inputControlVis 7 22 +15
lens 3 28 +25
lists 0 45 +45
maps 17 77 +60
ml 24 239 +215
observability 4 24 +20
presentationUtil 2 7 +5
reporting 0 5 +5
savedObjectsManagement 8 18 +10
securitySolution 69 139 +70
stackAlerts 12 57 +45
synthetics 10 20 +10
threatIntelligence 0 5 +5
timelines 0 20 +20
transform 1 116 +115
triggersActionsUi 0 5 +5
unifiedFieldList 0 30 +30
unifiedSearch 9 24 +15
upgradeAssistant 7 12 +5
ux 3 8 +5
visDefaultEditor 0 15 +15
visTypeTimelion 0 10 +10
visTypeTimeseries 10 70 +60
visTypeVega 0 5 +5
total +1082

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit c7b742c into elastic:main Oct 10, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data Views] Rename the title key in data view attributes
5 participants