Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data Views] Rename the title key in data view attributes #135451

Closed
shivindera opened this issue Jun 29, 2022 · 2 comments · Fixed by #142945
Closed

[Data Views] Rename the title key in data view attributes #135451

shivindera opened this issue Jun 29, 2022 · 2 comments · Fixed by #142945
Assignees
@mattkime
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort technical debt Improvement of the software architecture and operational architecture

Comments

@shivindera
Copy link
Contributor

No that we have the name key in DataViews, we should rename the title key in DataViews to something more meaningful like pattern or index or etc.

Reference to the discussion - #124191 (comment)
@shivindera shivindera added technical debt Improvement of the software architecture and operational architecture Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Team:AppServicesSv labels Jun 29, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@exalate-issue-sync exalate-issue-sync bot added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Jul 21, 2022
@exalate-issue-sync exalate-issue-sync bot changed the title Rename the title key in DataViews [Data Views] Rename the title key in data view attributes Jul 29, 2022
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Jul 29, 2022
@tsullivan
Copy link
Member

tsullivan commented Aug 17, 2022 •
edited
Loading

#124191 (comment)

I don't think the existing title should stay as such since its so misleading ALTHOUGH I would keep it the same in the saved object to avoid migration. We could introduce an indexPattern attribute, temporarily keeping title and migrating over time.

@exalate-issue-sync exalate-issue-sync bot added loe:x-large Extra Large Level of Effort and removed loe:medium Medium Level of Effort labels Aug 18, 2022
@tsullivan tsullivan mentioned this issue Aug 18, 2022
Closed
9 tasks
@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:x-large Extra Large Level of Effort labels Sep 1, 2022
@mattkime mattkime mentioned this issue Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattkime mattkime

Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
5 participants
@mattkime @tsullivan @legrego @shivindera @elasticmachine