Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataViews] deprecate dataViews.title #139153

Closed

Conversation

tsullivan
Copy link
Member

Summary

Closes #135451

  1. Deprecate dataViews.title, dataViews.getTitles, dataviews.getIdsWithTitle
  2. Stop using deprecated references in the data_view* plugins

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@tsullivan tsullivan added technical debt Improvement of the software architecture and operational architecture Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:AppServicesSv labels Aug 18, 2022
@tsullivan tsullivan force-pushed the dataviews/add-indexPattern-attr branch from b85831f to c4dcbee Compare August 18, 2022 22:27
@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 18, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #43 / apis index_patterns index_pattern_crud update_index_pattern main legacy index pattern api can update index_pattern title
  • [job] [logs] FTR Configs #43 / apis index_patterns index_pattern_crud update_index_pattern main legacy index pattern api can update index_pattern title
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution / CTI Enrichment with additional indicators Displays matched fields from both indicator match rules and investigation time enrichments on Threat Intel tab
  • [job] [logs] Jest Tests #3 / IndexPatterns should handle version conflicts
  • [job] [logs] Jest Tests #9 / should render BoundaryIndexExpression
  • [job] [logs] Jest Tests #9 / should render EntityIndexExpression
  • [job] [logs] Jest Tests #9 / should render EntityIndexExpression w/ invalid flag if invalid

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2428 2436 +8
dataViews 203 219 +16
total +24

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataViewEditor 31.9KB 32.0KB +72.0B
dataViewManagement 143.7KB 143.7KB +7.0B
total +79.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff errors
data 429.5KB 429.5KB +7.0B
dataViews 42.1KB 43.1KB +1.1KB ❌ 616.0B over limit
total +1.1KB
Unknown metric groups

API count

id before after diff
data 3114 3125 +11
dataViews 960 981 +21
total +32

ESLint disabled in files

id before after diff
apm 14 13 -1
observability 6 5 -1
total -2

ESLint disabled line counts

id before after diff
apm 81 78 -3
observability 44 43 -1
synthetics 57 51 -6
ux 10 9 -1
total -11

References to deprecated APIs

id before after diff
aiops 0 15 +15
apm 29 34 +5
controls 0 18 +18
data 9 59 +50
dataViewEditor 0 5 +5
dataViewFieldEditor 0 20 +20
dataViewManagement 35 60 +25
dataViews 24 69 +45
dataVisualizer 2 25 +23
discover 18 52 +34
fileUpload 0 1 +1
fleet 20 40 +20
graph 24 45 +21
infra 1 47 +46
inputControlVis 7 22 +15
lens 4 41 +37
lists 0 45 +45
maps 17 83 +66
ml 21 242 +221
observability 4 34 +30
presentationUtil 2 10 +8
reporting 0 5 +5
savedObjectsManagement 8 21 +13
security 59 60 +1
securitySolution 60 131 +71
stackAlerts 12 61 +49
synthetics 10 20 +10
threatIntelligence 0 10 +10
timelines 0 20 +20
transform 1 117 +116
triggersActionsUi 0 5 +5
unifiedSearch 9 21 +12
upgradeAssistant 7 12 +5
ux 3 8 +5
visDefaultEditor 0 15 +15
visTypeTimelion 0 10 +10
visTypeTimeseries 10 91 +81
visTypeVega 0 5 +5
total +1183

Total ESLint disabled count

id before after diff
apm 95 91 -4
observability 50 48 -2
synthetics 63 57 -6
ux 13 12 -1
total -13

Unreferenced deprecated APIs

id before after diff
data 6 8 +2
dataViews 0 3 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan closed this Sep 6, 2022
@tsullivan tsullivan deleted the dataviews/add-indexPattern-attr branch June 20, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data Views] Rename the title key in data view attributes
2 participants