-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Add functional tests for Index data visualizer's random sampler controls #142278
[ML] Add functional tests for Index data visualizer's random sampler controls #142278
Conversation
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, left a few comments.
x-pack/test/functional/services/ml/data_visualizer_index_based.ts
Outdated
Show resolved
Hide resolved
x-pack/test/functional/services/ml/data_visualizer_index_based.ts
Outdated
Show resolved
Hide resolved
x-pack/test/functional/services/ml/data_visualizer_index_based.ts
Outdated
Show resolved
Hide resolved
x-pack/test/functional/services/ml/data_visualizer_index_based.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM (with maybe required stability fixes).
Approving now as I'll be on vacation next week, but it'll be good to check this with the flaky runner before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Running flaky test suite runner... |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @qn895 |
Flaky test suite runner successful after 50 runs ✅ |
…controls (elastic#142278) Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 36f330e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Summary
This PR adds functional tests for Data visualizer's random sampler controls. It ensures that settings are retained when navigating to different index patterns/saved searches.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers