Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Increase Test Coverage 8.6.0 #142456

Closed
12 tasks done
peteharverson opened this issue Oct 3, 2022 · 2 comments
Closed
12 tasks done

[ML] Increase Test Coverage 8.6.0 #142456

peteharverson opened this issue Oct 3, 2022 · 2 comments

Comments

@peteharverson
Copy link
Contributor

peteharverson commented Oct 3, 2022

Follow up to #137573

Meta issue to summarize improvements to test coverage for 8.6.0.

Jest unit tests

API integration tests

Functional tests

Accessibility tests

part of #88496

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

alvarezmelissa87 added a commit that referenced this issue Nov 21, 2022
…esults_chart' (#145619)

## Summary

Related meta issue #142456

This PR adds api integration tests for the
`api/ml/results/datafeed_results_chart` endpoint


### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: Kibana Machine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 21, 2022
…esults_chart' (elastic#145619)

## Summary

Related meta issue elastic#142456

This PR adds api integration tests for the
`api/ml/results/datafeed_results_chart` endpoint

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit a74bfee)
kibanamachine referenced this issue Nov 22, 2022
…feed_results_chart' (#145619) (#145933)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[ML] Api Integration tests: adds tests for
'api/ml/results/datafeed_results_chart'
(#145619)](#145619)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Melissa
Alvarez","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-21T20:19:07Z","message":"[ML]
Api Integration tests: adds tests for
'api/ml/results/datafeed_results_chart' (#145619)\n\n##
Summary\r\n\r\nRelated meta issue
https://github.com/elastic/kibana/issues/142456\r\n\r\nThis PR adds api
integration tests for the\r\n`api/ml/results/datafeed_results_chart`
endpoint\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"a74bfee93f174e9cde586c27746053f71d899b55","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","test-api-integration","v8.6.0","v8.7.0"],"number":145619,"url":"https://github.com/elastic/kibana/pull/145619","mergeCommit":{"message":"[ML]
Api Integration tests: adds tests for
'api/ml/results/datafeed_results_chart' (#145619)\n\n##
Summary\r\n\r\nRelated meta issue
https://github.com/elastic/kibana/issues/142456\r\n\r\nThis PR adds api
integration tests for the\r\n`api/ml/results/datafeed_results_chart`
endpoint\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"a74bfee93f174e9cde586c27746053f71d899b55"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145619","number":145619,"mergeCommit":{"message":"[ML]
Api Integration tests: adds tests for
'api/ml/results/datafeed_results_chart' (#145619)\n\n##
Summary\r\n\r\nRelated meta issue
https://github.com/elastic/kibana/issues/142456\r\n\r\nThis PR adds api
integration tests for the\r\n`api/ml/results/datafeed_results_chart`
endpoint\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"a74bfee93f174e9cde586c27746053f71d899b55"}}]}]
BACKPORT-->

Co-authored-by: Melissa Alvarez <[email protected]>
alvarezmelissa87 added a commit that referenced this issue Nov 23, 2022
…ncers in the Anomaly Explorer (#146085)

## Summary

Related meta issue: #142456
Adds functional tests for filtering by influencers in the Anomaly
Explorer

Flaky test build
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1592


### Checklist

Delete any items that are not applicable to this PR.

- [x ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: Kibana Machine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 23, 2022
…ncers in the Anomaly Explorer (elastic#146085)

## Summary

Related meta issue: elastic#142456
Adds functional tests for filtering by influencers in the Anomaly
Explorer

Flaky test build
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1592

### Checklist

Delete any items that are not applicable to this PR.

- [x ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 395fe5a)
kibanamachine referenced this issue Nov 23, 2022
…influencers in the Anomaly Explorer (#146085) (#146215)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[ML] Anomaly Detection: Adds functional tests for filtering by
influencers in the Anomaly Explorer
(#146085)](#146085)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Melissa
Alvarez","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-23T19:00:34Z","message":"[ML]
Anomaly Detection: Adds functional tests for filtering by influencers in
the Anomaly Explorer (#146085)\n\n## Summary\r\n\r\nRelated meta issue:
https://github.com/elastic/kibana/issues/142456\r\nAdds functional tests
for filtering by influencers in the Anomaly\r\nExplorer\r\n\r\nFlaky
test
build\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1592\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"395fe5a0919d190cd8333af96c787efc36e4a389","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","test_ui_functional","release_note:skip","v8.6.0","v8.7.0"],"number":146085,"url":"https://github.com/elastic/kibana/pull/146085","mergeCommit":{"message":"[ML]
Anomaly Detection: Adds functional tests for filtering by influencers in
the Anomaly Explorer (#146085)\n\n## Summary\r\n\r\nRelated meta issue:
https://github.com/elastic/kibana/issues/142456\r\nAdds functional tests
for filtering by influencers in the Anomaly\r\nExplorer\r\n\r\nFlaky
test
build\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1592\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"395fe5a0919d190cd8333af96c787efc36e4a389"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146085","number":146085,"mergeCommit":{"message":"[ML]
Anomaly Detection: Adds functional tests for filtering by influencers in
the Anomaly Explorer (#146085)\n\n## Summary\r\n\r\nRelated meta issue:
https://github.com/elastic/kibana/issues/142456\r\nAdds functional tests
for filtering by influencers in the Anomaly\r\nExplorer\r\n\r\nFlaky
test
build\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1592\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"395fe5a0919d190cd8333af96c787efc36e4a389"}}]}]
BACKPORT-->

Co-authored-by: Melissa Alvarez <[email protected]>
darnautov added a commit that referenced this issue Nov 30, 2022
## Summary

Part of #142456

Adds functional tests for the Test model action


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 30, 2022
## Summary

Part of elastic#142456

Adds functional tests for the Test model action

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 9ad78b2)
kibanamachine added a commit that referenced this issue Nov 30, 2022
)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[ML] Functional tests for the Test Model action
(#146399)](#146399)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-30T15:48:27Z","message":"[ML]
Functional tests for the Test Model action (#146399)\n\n##
Summary\r\n\r\nPart of #142456\r\n\r\nAdds functional tests for the Test
model action\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"9ad78b244abb24eb0dc7f6c15ee511883a4d0ac1","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","test_ui_functional","release_note:skip","Team:ML","v8.6.0","v8.7.0"],"number":146399,"url":"https://github.com/elastic/kibana/pull/146399","mergeCommit":{"message":"[ML]
Functional tests for the Test Model action (#146399)\n\n##
Summary\r\n\r\nPart of #142456\r\n\r\nAdds functional tests for the Test
model action\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"9ad78b244abb24eb0dc7f6c15ee511883a4d0ac1"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146399","number":146399,"mergeCommit":{"message":"[ML]
Functional tests for the Test Model action (#146399)\n\n##
Summary\r\n\r\nPart of #142456\r\n\r\nAdds functional tests for the Test
model action\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"9ad78b244abb24eb0dc7f6c15ee511883a4d0ac1"}}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <[email protected]>
peteharverson added a commit that referenced this issue Dec 7, 2022
## Summary

Adds tests to check the response of the index exists endpoint:

```
/api/ml/index_exists
```

Also fixed the behavior of the endpoint when passed an index with a
wilcard expression so that it no longer returns `true` if an index does
not exist matching the expression by adding `allow_no_indices: false` to
the query parameters.

Part of #142456


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: Kibana Machine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 7, 2022
## Summary

Adds tests to check the response of the index exists endpoint:

```
/api/ml/index_exists
```

Also fixed the behavior of the endpoint when passed an index with a
wilcard expression so that it no longer returns `true` if an index does
not exist matching the expression by adding `allow_no_indices: false` to
the query parameters.

Part of elastic#142456

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 4294e3b)
kibanamachine referenced this issue Dec 7, 2022
# Backport

This will backport the following commits from `main` to `8.6`:
- [[ML] Add API tests for index exists endpoint
(#146400)](#146400)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pete
Harverson","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-12-07T13:12:17Z","message":"[ML]
Add API tests for index exists endpoint (#146400)\n\n##
Summary\r\n\r\nAdds tests to check the response of the index exists
endpoint:\r\n\r\n```\r\n/api/ml/index_exists\r\n```\r\n\r\nAlso fixed
the behavior of the endpoint when passed an index with a\r\nwilcard
expression so that it no longer returns `true` if an index does\r\nnot
exist matching the expression by adding `allow_no_indices: false`
to\r\nthe query parameters.\r\n\r\nPart of
https://github.com/elastic/kibana/issues/142456\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"4294e3b17f559a0073f5453a47df7e9dc83c58ba","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review",":ml","release_note:skip","test-api-integration","v8.6.0","v8.7.0"],"number":146400,"url":"https://github.com/elastic/kibana/pull/146400","mergeCommit":{"message":"[ML]
Add API tests for index exists endpoint (#146400)\n\n##
Summary\r\n\r\nAdds tests to check the response of the index exists
endpoint:\r\n\r\n```\r\n/api/ml/index_exists\r\n```\r\n\r\nAlso fixed
the behavior of the endpoint when passed an index with a\r\nwilcard
expression so that it no longer returns `true` if an index does\r\nnot
exist matching the expression by adding `allow_no_indices: false`
to\r\nthe query parameters.\r\n\r\nPart of
https://github.com/elastic/kibana/issues/142456\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"4294e3b17f559a0073f5453a47df7e9dc83c58ba"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146400","number":146400,"mergeCommit":{"message":"[ML]
Add API tests for index exists endpoint (#146400)\n\n##
Summary\r\n\r\nAdds tests to check the response of the index exists
endpoint:\r\n\r\n```\r\n/api/ml/index_exists\r\n```\r\n\r\nAlso fixed
the behavior of the endpoint when passed an index with a\r\nwilcard
expression so that it no longer returns `true` if an index does\r\nnot
exist matching the expression by adding `allow_no_indices: false`
to\r\nthe query parameters.\r\n\r\nPart of
https://github.com/elastic/kibana/issues/142456\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"4294e3b17f559a0073f5453a47df7e9dc83c58ba"}}]}]
BACKPORT-->

Co-authored-by: Pete Harverson <[email protected]>
@peteharverson
Copy link
Contributor Author

Closing issue as all the tests planned for 8.6 have been completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants