Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Detections] increases coverage of bulk edit rules action according to test plan #141929
[Security Solution][Detections] increases coverage of bulk edit rules action according to test plan #141929
Changes from 20 commits
185f038
fdcb49d
e408920
41d8fe5
8cb33ba
607ac43
636067e
4dddec4
323bbe9
f97927e
5beef77
0c734f7
7ff763c
9bf93aa
fce583e
159309a
f486ac1
dea07e3
fb83b65
aa812e5
7c10ab7
d229959
fc7daef
79c5b1a
147194d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need prebuilt rules for this test case? Installation of all prebuilt rules is a heavy and error-prone operation that often fails due to timeouts. And that's not clear from the test body why we even need prebuilt rules here.
If prebuilt rules are required to check that the "Custom rules cannot be edited" modal is not displayed, I would isolate that in a separate test case and make an explicit check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not only to ensure no modal displayed, but also to ensure no errors happened when successfully applying both add and overwrite actions to custom and prebuilt rules