[Security Solution][Detections] increases coverage of bulk edit rules action according to test plan #141929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaliidm
added
test-coverage
# Conflicts: # x-pack/plugins/security_solution/cypress/e2e/detection_rules/custom_query_rule.cy.ts # x-pack/plugins/security_solution/cypress/screens/create_new_rule.ts # x-pack/plugins/security_solution/cypress/tasks/create_new_rule.ts
…hub.com/vitaliidm/kibana into detections/bulk-edit-rule-actions-tests
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
xcrzx
reviewed
Oct 5, 2022
| it('Overwrite rule actions in rules', () => { | ||
| const expectedActionFrequency = 'On each rule execution'; | ||
|
|
||
| loadPrebuiltDetectionRulesFromHeaderBtn(); |
There was a problem hiding this comment.
Why do we need prebuilt rules for this test case? Installation of all prebuilt rules is a heavy and error-prone operation that often fails due to timeouts. And that's not clear from the test body why we even need prebuilt rules here.
If prebuilt rules are required to check that the "Custom rules cannot be edited" modal is not displayed, I would isolate that in a separate test case and make an explicit check.
There was a problem hiding this comment.
It's not only to ensure no modal displayed, but also to ensure no errors happened when successfully applying both add and overwrite actions to custom and prebuilt rules
x-pack/plugins/security_solution/cypress/e2e/detection_rules/bulk_edit_rules_actions.cy.ts
Show resolved
Hide resolved
x-pack/plugins/security_solution/cypress/e2e/detection_rules/bulk_edit_rules_actions.cy.ts
Show resolved
Hide resolved
x-pack/plugins/security_solution/cypress/e2e/detection_rules/bulk_edit_rules_actions.cy.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/cypress/e2e/detection_rules/bulk_edit_rules_actions.cy.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/cypress/e2e/detection_rules/bulk_edit_rules_actions.cy.ts
Outdated
Show resolved
Hide resolved
…hub.com/vitaliidm/kibana into detections/bulk-edit-rule-actions-tests
|
@xcrzx feedback has been addressed |
Files by Code Ownerelastic/security-detections-response
elastic/security-detections-response-alerts
elastic/security-detections-response-rules
elastic/security-solution
elastic/security-threat-hunting
|
andrew-goldstein
approved these changes
Oct 6, 2022
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @vitaliidm |
xcrzx
approved these changes
Oct 10, 2022
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 10, 2022
… action according to test plan (elastic#141929) ## Summary - adds missing tests according to [test plan](https://docs.google.com/document/d/116x7ITTTJQ6cTiwaGK831_f6Ox7XB3qyLiHxC3Cmf8w/edit#heading=h.tzaw2977z8ue) (internal document) - small refactoring of cypress tasks related to rule actions: create Email connector moved to common tasks from create_rule screen, as it used in bulk editing as well (cherry picked from commit d07301f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 10, 2022
… action according to test plan (#141929) (#142978) ## Summary - adds missing tests according to [test plan](https://docs.google.com/document/d/116x7ITTTJQ6cTiwaGK831_f6Ox7XB3qyLiHxC3Cmf8w/edit#heading=h.tzaw2977z8ue) (internal document) - small refactoring of cypress tasks related to rule actions: create Email connector moved to common tasks from create_rule screen, as it used in bulk editing as well (cherry picked from commit d07301f) Co-authored-by: Vitalii Dmyterko <[email protected]>
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 11, 2022
… action according to test plan (elastic#141929) ## Summary - adds missing tests according to [test plan](https://docs.google.com/document/d/116x7ITTTJQ6cTiwaGK831_f6Ox7XB3qyLiHxC3Cmf8w/edit#heading=h.tzaw2977z8ue) (internal document) - small refactoring of cypress tasks related to rule actions: create Email connector moved to common tasks from create_rule screen, as it used in bulk editing as well
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 14, 2022
… action according to test plan (elastic#141929) ## Summary - adds missing tests according to [test plan](https://docs.google.com/document/d/116x7ITTTJQ6cTiwaGK831_f6Ox7XB3qyLiHxC3Cmf8w/edit#heading=h.tzaw2977z8ue) (internal document) - small refactoring of cypress tasks related to rule actions: create Email connector moved to common tasks from create_rule screen, as it used in bulk editing as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary