Migrate server-side rendering service to packages
#141902
Conversation
…-ref HEAD~1..HEAD --fix'
pgayvallet
added
Team:Core
| # @kbn/core-plugins-base-server-internal | ||
|
|
||
| This package contains base internal types of the `plugins` domain used across other core domains. |
There was a problem hiding this comment.
As encountered in some other places, and described here we had a cyclic dependency between the plugins domain and rendering/httpResources:
plugins -> CoreSetup/Start -> rendering -> plugins.
I broke the cycle by introducing this base package.
| @@ -7,6 +7,7 @@ | |||
| */ | |||
|
|
|||
| export { RenderingService } from './rendering_service'; | |||
| export { Fonts } from './views'; | |||
There was a problem hiding this comment.
TIL that the security plugin was using this internal react component (see x-pack/plugins/security/server/prompt_page.tsx).
If at some point we have more usages of our internal components related to the page templating we should think about extracting them to a public utility package, but given there was one single usage of it, I just adapted the import to point to @kbn/core-rendering-server-internal (and had to export the component from the entrypoint)
| /** @internal */ | ||
| export interface IRenderOptions { |
There was a problem hiding this comment.
Was wrongly annotated as public, this interface is only used internally.
| @@ -7,3 +7,4 @@ | |||
| */ | |||
|
|
|||
| export { Template } from './template'; | |||
| export { Fonts } from './fonts'; | |||
There was a problem hiding this comment.
TIL I learnt about this whole subdomain!
|
Pinging @elastic/kibana-core (Team:Core) |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Public APIs missing exports
Unknown metric groupsAPI count
ESLint disabled in files
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
* create empty packages * moves files to packages * adapt usages * updating READMEs and packages jsons * [CI] Auto-commit changed files from 'node scripts/generate codeowners' * adapt more usages * more import fixes * fix mock method names * export the `Fonts` component for security... * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * fix more usages again * includes tsx files Co-authored-by: kibanamachine <[email protected]>
* create empty packages * moves files to packages * adapt usages * updating READMEs and packages jsons * [CI] Auto-commit changed files from 'node scripts/generate codeowners' * adapt more usages * more import fixes * fix mock method names * export the `Fonts` component for security... * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * fix more usages again * includes tsx files Co-authored-by: kibanamachine <[email protected]>
Summary
Fix #136040
Create the following packages:
@kbn/core-plugins-base-server-internal@kbn/core-rendering-server-internal@kbn/core-rendering-server-mocks