Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate core domain services to packages: Server-side Rendering service #136040

Closed
TinaHeiligers opened this issue Jul 8, 2022 · 2 comments · Fixed by #141902
Closed

Migrate core domain services to packages: Server-side Rendering service #136040

TinaHeiligers opened this issue Jul 8, 2022 · 2 comments · Fixed by #141902
Assignees
Labels
chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@TinaHeiligers
Copy link
Contributor

Part of #134112
See #134137 for more context

Extract the Rendering service/domain (src/core/server/rendering) to packages.

Depends on:

  • elasticsearch
  • http
  • status (no direct dependency on rendering)
  • plugins

Imports:

New packages:

@kbn/core-rendering-server
@kbn/core-rendering-server-internal
@kbn/core-rendering-server-mocks

Dependency analysis:

Core-services:

/** @internal */
export interface RenderingSetupDeps {
elasticsearch: InternalElasticsearchServiceSetup;
http: InternalHttpServiceSetup;
status: InternalStatusServiceSetup;
uiPlugins: UiPlugins;
}

Other:

crypto
react (for rendering static markup)
react-dom/server
rxjs
rxjs/operators
@kbn/config
@kbn/core-base-common
@kbn/core-base-server-internal
@kbn/i18n
@kbn/ui-shared-deps-npm
@kbn/core-injected-metadata-common-internal
@kbn/utility-types(mocks)

@TinaHeiligers TinaHeiligers added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc EnableJiraSync labels Jul 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@TinaHeiligers
Copy link
Contributor Author

TinaHeiligers commented Sep 27, 2022

Hey @pgayvallet have you started on this work or can I help and take it on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants