[Fleet] added cardinality agg when counting acks in action_status #141651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaElastic
added
release_note:skip
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
nchaulet
reviewed
Sep 23, 2022
| @@ -39,6 +39,11 @@ export async function getActionStatuses( | |||
| terms: { field: 'action_id', size: actions.length || 10 }, | |||
| aggs: { | |||
| max_timestamp: { max: { field: '@timestamp' } }, | |||
| agent_count: { | |||
| cardinality: { | |||
| field: 'agent_id', | |||
There was a problem hiding this comment.
Should we use precision_threshold here to have a more accurate response https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-metrics-cardinality-aggregation.html ?
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
nchaulet
approved these changes
Sep 26, 2022
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 26, 2022
…astic#141651) * added cardinality agg when counting acks in action_status * added precision_threshold, added tests for activity flyout * fixed tests * fixed tests Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit adffaa4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 26, 2022
…41651) (#141764) * added cardinality agg when counting acks in action_status * added precision_threshold, added tests for activity flyout * fixed tests * fixed tests Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit adffaa4) Co-authored-by: Julia Bardi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #140267
During scalability testing with 75k agents, we encountered an issue that the number of acks for an action were greater than the agents actioned, this resulted the action showing up as in progress.
It is possible that one agent acks multiple times, if the update of action result takes long, and the agent checks in multiple times.
To fix this, added a cardinality agg on agent id when fetching action results, to make sure we are only counting one ack per agent.
The fix is hard to reproduce locally with small agent count, so would have to be tested again with larger clusters on cloud.
cc @joshdover