-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Fleet] added cardinality agg when counting acks in action_status (#1…
…41651) (#141764) * added cardinality agg when counting acks in action_status * added precision_threshold, added tests for activity flyout * fixed tests * fixed tests Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit adffaa4) Co-authored-by: Julia Bardi <[email protected]>
- Loading branch information
1 parent
a5427db
commit b7f4447
Showing
3 changed files
with
341 additions
and
9 deletions.
There are no files selected for viewing
316 changes: 316 additions & 0 deletions
316
...lications/fleet/sections/agents/agent_list_page/components/agent_activity_flyout.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,316 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import React from 'react'; | ||
| import { act, render, fireEvent } from '@testing-library/react'; | ||
| // eslint-disable-next-line @kbn/eslint/module_migration | ||
| import { IntlProvider } from 'react-intl'; | ||
|
|
||
| import { useActionStatus } from '../hooks'; | ||
| import { useGetAgentPolicies, useStartServices } from '../../../../hooks'; | ||
|
|
||
| import { AgentActivityFlyout } from './agent_activity_flyout'; | ||
|
|
||
| jest.mock('../hooks'); | ||
| jest.mock('../../../../hooks'); | ||
|
|
||
| const mockUseActionStatus = useActionStatus as jest.Mock; | ||
| const mockUseGetAgentPolicies = useGetAgentPolicies as jest.Mock; | ||
| const mockUseStartServices = useStartServices as jest.Mock; | ||
|
|
||
| describe('AgentActivityFlyout', () => { | ||
| const mockOnClose = jest.fn(); | ||
| const mockOnAbortSuccess = jest.fn(); | ||
| const mockAbortUpgrade = jest.fn(); | ||
|
|
||
| beforeEach(() => { | ||
| mockOnClose.mockReset(); | ||
| mockOnAbortSuccess.mockReset(); | ||
| mockAbortUpgrade.mockReset(); | ||
| mockUseActionStatus.mockReset(); | ||
| mockUseGetAgentPolicies.mockReturnValue({ | ||
| data: { | ||
| items: [ | ||
| { id: 'policy1', name: 'Policy 1' }, | ||
| { id: 'policy2', name: 'Policy 2' }, | ||
| ], | ||
| }, | ||
| }); | ||
| mockUseStartServices.mockReturnValue({ | ||
| docLinks: { links: { fleet: { upgradeElasticAgent: 'https://elastic.co' } } }, | ||
| }); | ||
| }); | ||
|
|
||
| beforeEach(() => { | ||
| jest.useFakeTimers('modern').setSystemTime(new Date('2022-09-15T10:00:00.000Z')); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| jest.useRealTimers(); | ||
| }); | ||
|
|
||
| const renderComponent = () => { | ||
| return render( | ||
| <IntlProvider timeZone="UTC" locale="en"> | ||
| <AgentActivityFlyout | ||
| onClose={mockOnClose} | ||
| onAbortSuccess={mockOnAbortSuccess} | ||
| refreshAgentActivity={false} | ||
| /> | ||
| </IntlProvider> | ||
| ); | ||
| }; | ||
|
|
||
| it('should render agent activity for in progress upgrade', () => { | ||
| const mockActionStatuses = [ | ||
| { | ||
| actionId: 'action2', | ||
| nbAgentsActionCreated: 5, | ||
| nbAgentsAck: 0, | ||
| version: '8.5.0', | ||
| startTime: '2022-09-15T10:00:00.000Z', | ||
| type: 'UPGRADE', | ||
| nbAgentsActioned: 5, | ||
| status: 'IN_PROGRESS', | ||
| expiration: '2099-09-16T10:00:00.000Z', | ||
| creationTime: '2022-09-15T10:00:00.000Z', | ||
| nbAgentsFailed: 0, | ||
| }, | ||
| ]; | ||
| mockUseActionStatus.mockReturnValue({ | ||
| currentActions: mockActionStatuses, | ||
| abortUpgrade: mockAbortUpgrade, | ||
| isFirstLoading: true, | ||
| }); | ||
| const result = renderComponent(); | ||
|
|
||
| expect(result.getByText('Agent activity')).toBeInTheDocument(); | ||
|
|
||
| expect( | ||
| result.container.querySelector('[data-test-subj="upgradeInProgressTitle"]')!.textContent | ||
| ).toEqual('Upgrading 5 agents to version 8.5.0'); | ||
| // compare without whitespace, doesn't match | ||
| expect( | ||
| result.container | ||
| .querySelector('[data-test-subj="upgradeInProgressDescription"]')! | ||
| .textContent?.replace(/\s/g, '') | ||
| ).toContain('Started on Sep 15, 2022 10:00 AM. Learn more'.replace(/\s/g, '')); | ||
|
|
||
| act(() => { | ||
| fireEvent.click(result.getByText('Abort upgrade')); | ||
| }); | ||
|
|
||
| expect(mockAbortUpgrade).toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('should render agent activity for scheduled upgrade', () => { | ||
| const mockActionStatuses = [ | ||
| { | ||
| actionId: 'action2', | ||
| nbAgentsActionCreated: 5, | ||
| nbAgentsAck: 0, | ||
| version: '8.5.0', | ||
| startTime: '2022-09-16T10:00:00.000Z', | ||
| type: 'UPGRADE', | ||
| nbAgentsActioned: 5, | ||
| status: 'IN_PROGRESS', | ||
| expiration: '2099-09-17T10:00:00.000Z', | ||
| creationTime: '2022-09-15T10:00:00.000Z', | ||
| nbAgentsFailed: 0, | ||
| }, | ||
| ]; | ||
| mockUseActionStatus.mockReturnValue({ | ||
| currentActions: mockActionStatuses, | ||
| abortUpgrade: mockAbortUpgrade, | ||
| isFirstLoading: true, | ||
| }); | ||
| const result = renderComponent(); | ||
|
|
||
| expect(result.getByText('Agent activity')).toBeInTheDocument(); | ||
|
|
||
| expect( | ||
| result.container.querySelector('[data-test-subj="upgradeInProgressTitle"]')!.textContent | ||
| ).toEqual('5 agents scheduled to upgrade to version 8.5.0'); | ||
| expect( | ||
| result.container | ||
| .querySelector('[data-test-subj="upgradeInProgressDescription"]')! | ||
| .textContent?.replace(/\s/g, '') | ||
| ).toContain('Scheduled for Sep 16, 2022 10:00 AM. Learn more'.replace(/\s/g, '')); | ||
|
|
||
| act(() => { | ||
| fireEvent.click(result.getByText('Abort upgrade')); | ||
| }); | ||
|
|
||
| expect(mockAbortUpgrade).toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('should render agent activity for complete upgrade', () => { | ||
| const mockActionStatuses = [ | ||
| { | ||
| actionId: 'action3', | ||
| nbAgentsActionCreated: 2, | ||
| nbAgentsAck: 2, | ||
| type: 'UPGRADE', | ||
| nbAgentsActioned: 2, | ||
| status: 'COMPLETE', | ||
| expiration: '2099-09-16T10:00:00.000Z', | ||
| creationTime: '2022-09-15T10:00:00.000Z', | ||
| nbAgentsFailed: 0, | ||
| completionTime: '2022-09-15T12:00:00.000Z', | ||
| }, | ||
| ]; | ||
| mockUseActionStatus.mockReturnValue({ | ||
| currentActions: mockActionStatuses, | ||
| abortUpgrade: mockAbortUpgrade, | ||
| isFirstLoading: true, | ||
| }); | ||
| const result = renderComponent(); | ||
|
|
||
| expect(result.container.querySelector('[data-test-subj="statusTitle"]')!.textContent).toEqual( | ||
| '2 agents upgraded' | ||
| ); | ||
| expect( | ||
| result.container | ||
| .querySelector('[data-test-subj="statusDescription"]')! | ||
| .textContent?.replace(/\s/g, '') | ||
| ).toContain('Completed Sep 15, 2022 12:00 PM'.replace(/\s/g, '')); | ||
| }); | ||
|
|
||
| it('should render agent activity for expired unenroll', () => { | ||
| const mockActionStatuses = [ | ||
| { | ||
| actionId: 'action4', | ||
| nbAgentsActionCreated: 3, | ||
| nbAgentsAck: 0, | ||
| type: 'UNENROLL', | ||
| nbAgentsActioned: 3, | ||
| status: 'EXPIRED', | ||
| expiration: '2022-09-14T10:00:00.000Z', | ||
| creationTime: '2022-09-15T10:00:00.000Z', | ||
| nbAgentsFailed: 0, | ||
| }, | ||
| ]; | ||
| mockUseActionStatus.mockReturnValue({ | ||
| currentActions: mockActionStatuses, | ||
| abortUpgrade: mockAbortUpgrade, | ||
| isFirstLoading: true, | ||
| }); | ||
| const result = renderComponent(); | ||
|
|
||
| expect(result.container.querySelector('[data-test-subj="statusTitle"]')!.textContent).toEqual( | ||
| 'Agent unenrollment expired' | ||
| ); | ||
| expect( | ||
| result.container | ||
| .querySelector('[data-test-subj="statusDescription"]')! | ||
| .textContent?.replace(/\s/g, '') | ||
| ).toContain('Expired on Sep 14, 2022 10:00 AM'.replace(/\s/g, '')); | ||
| }); | ||
|
|
||
| it('should render agent activity for cancelled upgrade', () => { | ||
| const mockActionStatuses = [ | ||
| { | ||
| actionId: 'action5', | ||
| nbAgentsActionCreated: 3, | ||
| nbAgentsAck: 0, | ||
| startTime: '2022-09-15T10:00:00.000Z', | ||
| type: 'UPGRADE', | ||
| nbAgentsActioned: 3, | ||
| status: 'CANCELLED', | ||
| expiration: '2099-09-16T10:00:00.000Z', | ||
| creationTime: '2022-09-15T10:00:00.000Z', | ||
| nbAgentsFailed: 0, | ||
| cancellationTime: '2022-09-15T11:00:00.000Z', | ||
| }, | ||
| ]; | ||
| mockUseActionStatus.mockReturnValue({ | ||
| currentActions: mockActionStatuses, | ||
| abortUpgrade: mockAbortUpgrade, | ||
| isFirstLoading: true, | ||
| }); | ||
| const result = renderComponent(); | ||
|
|
||
| expect(result.container.querySelector('[data-test-subj="statusTitle"]')!.textContent).toEqual( | ||
| 'Agent upgrade cancelled' | ||
| ); | ||
| expect( | ||
| result.container | ||
| .querySelector('[data-test-subj="statusDescription"]')! | ||
| .textContent?.replace(/\s/g, '') | ||
| ).toContain('Cancelled on Sep 15, 2022 11:00 AM'.replace(/\s/g, '')); | ||
| }); | ||
|
|
||
| it('should render agent activity for failed reassign', () => { | ||
| const mockActionStatuses = [ | ||
| { | ||
| actionId: 'action7', | ||
| nbAgentsActionCreated: 1, | ||
| nbAgentsAck: 0, | ||
| type: 'POLICY_REASSIGN', | ||
| nbAgentsActioned: 1, | ||
| status: 'FAILED', | ||
| expiration: '2099-09-16T10:00:00.000Z', | ||
| newPolicyId: 'policy1', | ||
| creationTime: '2022-09-15T10:00:00.000Z', | ||
| nbAgentsFailed: 1, | ||
| completionTime: '2022-09-15T11:00:00.000Z', | ||
| }, | ||
| ]; | ||
| mockUseActionStatus.mockReturnValue({ | ||
| currentActions: mockActionStatuses, | ||
| abortUpgrade: mockAbortUpgrade, | ||
| isFirstLoading: true, | ||
| }); | ||
| const result = renderComponent(); | ||
|
|
||
| expect(result.container.querySelector('[data-test-subj="statusTitle"]')!.textContent).toEqual( | ||
| '0 of 1 agent assigned to a new policy' | ||
| ); | ||
| expect( | ||
| result.container | ||
| .querySelector('[data-test-subj="statusDescription"]')! | ||
| .textContent?.replace(/\s/g, '') | ||
| ).toContain( | ||
| 'A problem occurred during this operation. Started on Sep 15, 2022 10:00 AM.'.replace( | ||
| /\s/g, | ||
| '' | ||
| ) | ||
| ); | ||
| }); | ||
|
|
||
| it('should render agent activity for unknown action', () => { | ||
| const mockActionStatuses = [ | ||
| { | ||
| actionId: 'action8', | ||
| nbAgentsActionCreated: 3, | ||
| nbAgentsAck: 0, | ||
| type: 'UNKNOWN', | ||
| nbAgentsActioned: 3, | ||
| status: 'COMPLETE', | ||
| expiration: '2022-09-14T10:00:00.000Z', | ||
| creationTime: '2022-09-15T10:00:00.000Z', | ||
| completionTime: '2022-09-15T12:00:00.000Z', | ||
| nbAgentsFailed: 0, | ||
| }, | ||
| ]; | ||
| mockUseActionStatus.mockReturnValue({ | ||
| currentActions: mockActionStatuses, | ||
| abortUpgrade: mockAbortUpgrade, | ||
| isFirstLoading: true, | ||
| }); | ||
| const result = renderComponent(); | ||
|
|
||
| expect(result.container.querySelector('[data-test-subj="statusTitle"]')!.textContent).toEqual( | ||
| '0 of 3 agents actioned' | ||
| ); | ||
| expect( | ||
| result.container | ||
| .querySelector('[data-test-subj="statusDescription"]')! | ||
| .textContent?.replace(/\s/g, '') | ||
| ).toContain('Completed Sep 15, 2022 12:00 PM'.replace(/\s/g, '')); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.