limit wait time for baselayer #14047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisljar
approved these changes
Sep 19, 2017
thomasneirynck
added
Feature:Visualizations
thomasneirynck
force-pushed
the
fix/baselayer_waittime
branch
from
04e32be to
0016cec
Compare
|
rebased on master |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Oct 4, 2017
thomasneirynck
added a commit
that referenced
this pull request
Oct 4, 2017
|
@thomasneirynck can we get this backported to 5.6? Otherwise Reporting with Tilemaps won't work for our last supported maintenance branch. |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Oct 4, 2017
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Oct 4, 2017
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Oct 4, 2017
This reverts commit 44a7107.
chrisronline
added a commit
that referenced
this pull request
Oct 5, 2017
* Adds ability to change index pattern on import Signed-off-by: Tyler Smalley <[email protected]> * UI changes. Use a table in the modal grouped by index pattern id instead of multiple modals. * PR feedback * PR feedback * PR updates * Handle skip properly * Fix error when there were no existing index patterns * Tests for the new import conflict logic * Fix invisible filters caused by missing index pattern (#14131) "invisible filters" occur when the mapping chain throws an error. If a single filter throws an error, the entire chain rejects. As a result, not even the valid filters appear in the filter bar because they never get added to the scope. However the filters still exist in app state and still get sent with each search request. The most common error occurs when the filter's meta.index property points to a non-existing index pattern. Since this property is only used for looking up field formatters and it is not essential for a working filter, we now fall back on raw values instead of failing if the index pattern is not found. See the PR this one replaces for discussion about other solutions we tried and why we chose to go this route. * Show query and filter bars even when there's a linked search (#14212) The query bar used to be hidden in the presence of a linked search because unlike filters, queries didn't get merged when flattening a SearchSource hierarchy. That means a query in the query bar would override the query in the linked search. This is no longer the case. As of 6.0 we include all queries in the SearchSource hierarchy in the final request, so there's no longer any reason to hide the query bar. Since filters created via a Vis show up in the query bar when Kuery is selected, these filters now appear correctly even when there's a linked search in the vis editor. Previously when unlinking a saved search visualize would insert the query and filters from the saved search into app state before removing the SearchSource from the hierarcy. This posed a problem because combining two lucene query strings isn't as easy as combing two sets of filters. We decided this behavior was a bit counterintuitive anyway. If the user wants to unlink the saved search, they probably want to discard it, not combine it with their local changes. So I've also updated the unlinking functionality to discard the saved search. * limit wait time for baselayer (#14047) * adding scope appy back (#14269) * remove junk tests (#14191) * We are using the index pattern id now * Use the index pattern id here too * Use an isolated es env for these tests * Revert "Fix invisible filters caused by missing index pattern (#14131)" This reverts commit e09d7ad. * Revert "Show query and filter bars even when there's a linked search (#14212)" This reverts commit 3aee7c2. * Revert "limit wait time for baselayer (#14047)" This reverts commit 44a7107. * Revert "adding scope appy back (#14269)" This reverts commit 51b6b51. * Revert "remove junk tests (#14191)" This reverts commit f06c183. * Revert these
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Oct 5, 2017
* Adds ability to change index pattern on import Signed-off-by: Tyler Smalley <[email protected]> * UI changes. Use a table in the modal grouped by index pattern id instead of multiple modals. * PR feedback * PR feedback * PR updates * Handle skip properly * Fix error when there were no existing index patterns * Tests for the new import conflict logic * Fix invisible filters caused by missing index pattern (elastic#14131) "invisible filters" occur when the mapping chain throws an error. If a single filter throws an error, the entire chain rejects. As a result, not even the valid filters appear in the filter bar because they never get added to the scope. However the filters still exist in app state and still get sent with each search request. The most common error occurs when the filter's meta.index property points to a non-existing index pattern. Since this property is only used for looking up field formatters and it is not essential for a working filter, we now fall back on raw values instead of failing if the index pattern is not found. See the PR this one replaces for discussion about other solutions we tried and why we chose to go this route. * Show query and filter bars even when there's a linked search (elastic#14212) The query bar used to be hidden in the presence of a linked search because unlike filters, queries didn't get merged when flattening a SearchSource hierarchy. That means a query in the query bar would override the query in the linked search. This is no longer the case. As of 6.0 we include all queries in the SearchSource hierarchy in the final request, so there's no longer any reason to hide the query bar. Since filters created via a Vis show up in the query bar when Kuery is selected, these filters now appear correctly even when there's a linked search in the vis editor. Previously when unlinking a saved search visualize would insert the query and filters from the saved search into app state before removing the SearchSource from the hierarcy. This posed a problem because combining two lucene query strings isn't as easy as combing two sets of filters. We decided this behavior was a bit counterintuitive anyway. If the user wants to unlink the saved search, they probably want to discard it, not combine it with their local changes. So I've also updated the unlinking functionality to discard the saved search. * limit wait time for baselayer (elastic#14047) * adding scope appy back (elastic#14269) * remove junk tests (elastic#14191) * We are using the index pattern id now * Use the index pattern id here too * Use an isolated es env for these tests * Revert "Fix invisible filters caused by missing index pattern (elastic#14131)" This reverts commit e09d7ad. * Revert "Show query and filter bars even when there's a linked search (elastic#14212)" This reverts commit 3aee7c2. * Revert "limit wait time for baselayer (elastic#14047)" This reverts commit 44a7107. * Revert "adding scope appy back (elastic#14269)" This reverts commit 51b6b51. * Revert "remove junk tests (elastic#14191)" This reverts commit f06c183. * Revert these
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Oct 5, 2017
* Adds ability to change index pattern on import Signed-off-by: Tyler Smalley <[email protected]> * UI changes. Use a table in the modal grouped by index pattern id instead of multiple modals. * PR feedback * PR feedback * PR updates * Handle skip properly * Fix error when there were no existing index patterns * Tests for the new import conflict logic * Fix invisible filters caused by missing index pattern (elastic#14131) "invisible filters" occur when the mapping chain throws an error. If a single filter throws an error, the entire chain rejects. As a result, not even the valid filters appear in the filter bar because they never get added to the scope. However the filters still exist in app state and still get sent with each search request. The most common error occurs when the filter's meta.index property points to a non-existing index pattern. Since this property is only used for looking up field formatters and it is not essential for a working filter, we now fall back on raw values instead of failing if the index pattern is not found. See the PR this one replaces for discussion about other solutions we tried and why we chose to go this route. * Show query and filter bars even when there's a linked search (elastic#14212) The query bar used to be hidden in the presence of a linked search because unlike filters, queries didn't get merged when flattening a SearchSource hierarchy. That means a query in the query bar would override the query in the linked search. This is no longer the case. As of 6.0 we include all queries in the SearchSource hierarchy in the final request, so there's no longer any reason to hide the query bar. Since filters created via a Vis show up in the query bar when Kuery is selected, these filters now appear correctly even when there's a linked search in the vis editor. Previously when unlinking a saved search visualize would insert the query and filters from the saved search into app state before removing the SearchSource from the hierarcy. This posed a problem because combining two lucene query strings isn't as easy as combing two sets of filters. We decided this behavior was a bit counterintuitive anyway. If the user wants to unlink the saved search, they probably want to discard it, not combine it with their local changes. So I've also updated the unlinking functionality to discard the saved search. * limit wait time for baselayer (elastic#14047) * adding scope appy back (elastic#14269) * remove junk tests (elastic#14191) * We are using the index pattern id now * Use the index pattern id here too * Use an isolated es env for these tests * Revert "Fix invisible filters caused by missing index pattern (elastic#14131)" This reverts commit e09d7ad. * Revert "Show query and filter bars even when there's a linked search (elastic#14212)" This reverts commit 3aee7c2. * Revert "limit wait time for baselayer (elastic#14047)" This reverts commit 44a7107. * Revert "adding scope appy back (elastic#14269)" This reverts commit 51b6b51. * Revert "remove junk tests (elastic#14191)" This reverts commit f06c183. * Revert these
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Oct 5, 2017
* Adds ability to change index pattern on import Signed-off-by: Tyler Smalley <[email protected]> * UI changes. Use a table in the modal grouped by index pattern id instead of multiple modals. * PR feedback * PR feedback * PR updates * Handle skip properly * Fix error when there were no existing index patterns * Tests for the new import conflict logic * Fix invisible filters caused by missing index pattern (elastic#14131) "invisible filters" occur when the mapping chain throws an error. If a single filter throws an error, the entire chain rejects. As a result, not even the valid filters appear in the filter bar because they never get added to the scope. However the filters still exist in app state and still get sent with each search request. The most common error occurs when the filter's meta.index property points to a non-existing index pattern. Since this property is only used for looking up field formatters and it is not essential for a working filter, we now fall back on raw values instead of failing if the index pattern is not found. See the PR this one replaces for discussion about other solutions we tried and why we chose to go this route. * Show query and filter bars even when there's a linked search (elastic#14212) The query bar used to be hidden in the presence of a linked search because unlike filters, queries didn't get merged when flattening a SearchSource hierarchy. That means a query in the query bar would override the query in the linked search. This is no longer the case. As of 6.0 we include all queries in the SearchSource hierarchy in the final request, so there's no longer any reason to hide the query bar. Since filters created via a Vis show up in the query bar when Kuery is selected, these filters now appear correctly even when there's a linked search in the vis editor. Previously when unlinking a saved search visualize would insert the query and filters from the saved search into app state before removing the SearchSource from the hierarcy. This posed a problem because combining two lucene query strings isn't as easy as combing two sets of filters. We decided this behavior was a bit counterintuitive anyway. If the user wants to unlink the saved search, they probably want to discard it, not combine it with their local changes. So I've also updated the unlinking functionality to discard the saved search. * limit wait time for baselayer (elastic#14047) * adding scope appy back (elastic#14269) * remove junk tests (elastic#14191) * We are using the index pattern id now * Use the index pattern id here too * Use an isolated es env for these tests * Revert "Fix invisible filters caused by missing index pattern (elastic#14131)" This reverts commit e09d7ad. * Revert "Show query and filter bars even when there's a linked search (elastic#14212)" This reverts commit 3aee7c2. * Revert "limit wait time for baselayer (elastic#14047)" This reverts commit 44a7107. * Revert "adding scope appy back (elastic#14269)" This reverts commit 51b6b51. * Revert "remove junk tests (elastic#14191)" This reverts commit f06c183. * Revert these
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Oct 6, 2017
thomasneirynck
added a commit
that referenced
this pull request
Oct 9, 2017
|
Checked in with @thomasneirynck. He will let the QA team know how to test this. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13765.
Adds a waittime-limit for baselayer loading.
If the baselayer takes more than 10 seconds to load, we will still fire a render-complete event. Previously, the visualization would wait indefinitely for the layer to load. This causes problems in Reporting when there are unstable connections and tiles get dropped.
The practical result of this change is that if the basemap is not loaded completely within 10 seconds, a report would still be generated. This report may have one or more 'gaps' where the missing tiles are.