-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Table list view] Integrate package into visualizations, maps, graphs #140040
Merged
sebelga
merged 35 commits into
elastic:table-list-view/enhance-ux
from
sebelga:table-list-view/integrate-package-vis-map-graph
Sep 14, 2022
Merged
Changes from 10 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
1c1ba58
Integrate package into visualizations plugin
sebelga 93b7d66
Integrate package into maps plugin
sebelga 06c3b44
Add unique id to tables
sebelga b4b610d
Fix i18n issue
sebelga dc56612
Integrate package into graph plugin
sebelga 1fa743e
Fix missing description attribute
sebelga 7296a66
Update findMaps() handler
sebelga 732d577
Fix i18n issue
sebelga 4314565
Add "onClickTitle" prop to navigate to details view
sebelga cef4d8a
Remove component from kibana-react plugin
sebelga 8287766
Fix visualisation editItem handler
sebelga 3d6db3c
Add unique id to graph table
sebelga 65f97fe
Fix i18n issue
sebelga 7703f5c
Fix link rendering when vis type is unknown
sebelga 70ed7d3
Fix TS issue
sebelga b3e5737
Remove getApplication from maps kibana services
sebelga 8faa861
Merge branch 'table-list-view/enhance-ux' into table-list-view/integr…
kibanamachine 73b6ba9
Use RedirectAppLinks to prevent full page reload
sebelga 2e54695
Merge branch 'table-list-view/integrate-package-vis-map-graph' of git…
sebelga 9c032e9
Merge branch 'table-list-view/enhance-ux' into table-list-view/integr…
kibanamachine 36365fa
Fix TS issues
sebelga 510aa18
Merge branch 'table-list-view/integrate-package-vis-map-graph' of git…
sebelga 411bb6c
Update to the new EuiPageTemplate component
sebelga 737a4f7
Fix functional tests
sebelga 656eb9c
Merge branch 'table-list-view/enhance-ux' into table-list-view/integr…
kibanamachine ddfe96e
[CI] Auto-commit changed files from 'node scripts/generate packages_b…
kibanamachine 435c721
Fix functional tests
sebelga b91722c
Merge branch 'table-list-view/integrate-package-vis-map-graph' of git…
sebelga 636b2d2
Merge branch 'table-list-view/enhance-ux' into table-list-view/integr…
kibanamachine 1195d6c
Revert "[CI] Auto-commit changed files from 'node scripts/generate pa…
sebelga a2a3e9a
Merge branch 'table-list-view/integrate-package-vis-map-graph' of git…
sebelga cb1e243
Add kibana.jsonc
sebelga 5697063
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
kibanamachine 42421b3
Merge branch 'table-list-view/enhance-ux' into table-list-view/integr…
kibanamachine 4a030f7
Merge branch 'table-list-view/enhance-ux' into table-list-view/integr…
kibanamachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 0 additions & 61 deletions
61
src/plugins/kibana_react/public/table_list_view/actions.ts
This file was deleted.
Oops, something went wrong.
80 changes: 0 additions & 80 deletions
80
src/plugins/kibana_react/public/table_list_view/components/confirm_delete_modal.tsx
This file was deleted.
Oops, something went wrong.
12 changes: 0 additions & 12 deletions
12
src/plugins/kibana_react/public/table_list_view/components/index.ts
This file was deleted.
Oops, something went wrong.
80 changes: 0 additions & 80 deletions
80
src/plugins/kibana_react/public/table_list_view/components/listing_limit_warning.tsx
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not having any issues locally without
eslint-disable-next-line
...? Can you check and see if this can be removed? Thanks!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's strange, after doing
yarn kbn bootstrap
did you restart the eslint server in VS Code? (or simply restart VS Code).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the eslint error that I get