[Table list view] Integrate package into visualizations, maps, graphs #140040

sebelga · 2022-09-05T15:33:46Z

In this PR I've integrated the package version of the <TableListView /> component into the following plugins:

Visualizations
Maps
Graphs

There aren't any new functionality added.

How to test

Launch the cloud deployment
Navigate to the app and make sure the list view renders correctly

Edit

This PR also update the Table list view to the new <EuiPageTemplate /> component

ThomThomson

Presentation team changes LGTM

rshen91 · 2022-09-06T14:27:02Z

packages/content-management/table_list/src/table_list_view.tsx

@@ -138,8 +162,18 @@ function TableListViewComp<T extends UserContentCommonSchema>({
        }),
        sortable: true,
        render: (field: keyof T, record: T) => (
+          // The validation is handled at the top of the component
+          // eslint-disable-next-line  @elastic/eui/href-or-on-click


I'm not having any issues locally without eslint-disable-next-line...? Can you check and see if this can be removed? Thanks!

That's strange, after doing yarn kbn bootstrap did you restart the eslint server in VS Code? (or simply restart VS Code).

This is the eslint error that I get

rshen91 · 2022-09-06T14:50:09Z

src/plugins/visualizations/public/visualize_app/components/visualize_listing.tsx

      headingId="visualizeListingHeading"
      // we allow users to create visualizations even if they can't save them
      // for data exploration purposes
      createItem={createNewVis}
-      tableCaption={i18n.translate('visualizations.listing.table.listTitle', {
-        defaultMessage: 'Visualize Library',
-      })}
      findItems={fetchItems}
      deleteItems={visualizeCapabilities.delete ? deleteItems : undefined}
      editItem={visualizeCapabilities.save ? editItem : undefined}


More a question than anything

edit.mp4

I'm testing locally and I'm having issues with the edit button with Lens specific visualizations with sample data...let me know what I'm missing thank you!

That's a great catch @rshen91 ! I fixed it in 8287766

flash1293

If a vis type can't be found, it's not handled gracefully anymore:

Old (warning label and not clickable):

New:
(doesn't show vis type, but still clickable - tries to navigate to "undefined")

You can test this case by changing the name of a vis type definition (for example here):

kibana/src/plugins/vis_types/gauge/public/vis_type/gauge.tsx

Line 25 in 14ba9b3

name: 'gauge',

sebelga · 2022-09-08T10:36:25Z

@elasticmachine merge upstream

…ate-package-vis-map-graph

sebelga · 2022-09-08T10:37:28Z

Thanks for the review @flash1293 ! Good catch for the page reload. I fixed it in 73b6ba9

…hub.com:sebelga/kibana into table-list-view/integrate-package-vis-map-graph

sebelga · 2022-09-08T14:07:12Z

To those subscribed to this PR notifications: I've had to update the TableListView to use the new <EuiPageTemplate /> as #139524 got merged. I updated the description with screenshots on how each app listing renders now.

flash1293 · 2022-09-12T07:05:32Z

The functional test failures here look legit

sebelga · 2022-09-13T10:46:55Z

@elasticmachine merge upstream

…ate-package-vis-map-graph

…uild_manifest'

…hub.com:sebelga/kibana into table-list-view/integrate-package-vis-map-graph

sebelga · 2022-09-13T14:43:28Z

@elasticmachine merge upstream

…ate-package-vis-map-graph

…ckages_build_manifest'" This reverts commit ddfe96e.

…hub.com:sebelga/kibana into table-list-view/integrate-package-vis-map-graph

sebelga · 2022-09-13T17:50:11Z

@elasticmachine merge upstream

…ate-package-vis-map-graph

sebelga · 2022-09-13T17:51:25Z

@elasticmachine merge upstream

…ate-package-vis-map-graph

kibana-ci · 2022-09-13T18:29:55Z

💔 Build Failed

Failed CI Steps

Post-Build

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [8eba3e6]

History

💔 Build #71869 failed 5697063
💔 Build #71810 failed 636b2d2
💔 Build #71686 failed b91722c
💔 Build #70759 failed 737a4f7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sebelga

Integrate package into visualizations plugin

1c1ba58

sebelga changed the title ~~Integrate package into visualizations plugin~~ [Table list view] Integrate package into visualizations, maps, graphs Sep 5, 2022

sebelga self-assigned this Sep 5, 2022

sebelga added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Feature:Content Management User generated content (saved objects) management labels Sep 5, 2022

sebelga added 9 commits September 5, 2022 17:40

Integrate package into maps plugin

93b7d66

Add unique id to tables

06c3b44

Fix i18n issue

b4b610d

Integrate package into graph plugin

dc56612

Fix missing description attribute

1fa743e

Update findMaps() handler

7296a66

Fix i18n issue

732d577

Add "onClickTitle" prop to navigate to details view

4314565

Remove component from kibana-react plugin

cef4d8a

sebelga added the ci:cloud-deploy Create or update a Cloud deployment label Sep 6, 2022

sebelga marked this pull request as ready for review September 6, 2022 14:14

sebelga requested a review from a team September 6, 2022 14:14

sebelga requested review from a team as code owners September 6, 2022 14:14

sebelga requested a review from rshen91 September 6, 2022 14:15

ThomThomson approved these changes Sep 6, 2022

View reviewed changes

sebelga mentioned this pull request Sep 6, 2022

[Table list view] Improve UX (phase 1) #135892

Merged

5 tasks

rshen91 reviewed Sep 6, 2022

View reviewed changes

Fix visualisation editItem handler

8287766

sebelga requested a review from rshen91 September 7, 2022 08:52

flash1293 requested changes Sep 7, 2022

View reviewed changes

sebelga added 2 commits September 7, 2022 10:49

Add unique id to graph table

3d6db3c

Fix i18n issue

65f97fe

Merge branch 'table-list-view/enhance-ux' into table-list-view/integr…

9c032e9

…ate-package-vis-map-graph

sebelga added 3 commits September 8, 2022 12:16

Fix TS issues

36365fa

Merge branch 'table-list-view/integrate-package-vis-map-graph' of git…

510aa18

…hub.com:sebelga/kibana into table-list-view/integrate-package-vis-map-graph

Update to the new EuiPageTemplate component

411bb6c

sebelga requested a review from flash1293 September 8, 2022 14:04

Fix functional tests

737a4f7

sebelga requested a review from a team as a code owner September 9, 2022 10:42

lukeelmers approved these changes Sep 9, 2022

View reviewed changes

kibanamachine and others added 4 commits September 13, 2022 04:47

Merge branch 'table-list-view/enhance-ux' into table-list-view/integr…

656eb9c

…ate-package-vis-map-graph

[CI] Auto-commit changed files from 'node scripts/generate packages_b…

ddfe96e

…uild_manifest'

Fix functional tests

435c721

Merge branch 'table-list-view/integrate-package-vis-map-graph' of git…

b91722c

…hub.com:sebelga/kibana into table-list-view/integrate-package-vis-map-graph

kibanamachine and others added 5 commits September 13, 2022 08:43

Merge branch 'table-list-view/enhance-ux' into table-list-view/integr…

636b2d2

…ate-package-vis-map-graph

Revert "[CI] Auto-commit changed files from 'node scripts/generate pa…

1195d6c

…ckages_build_manifest'" This reverts commit ddfe96e.

Merge branch 'table-list-view/integrate-package-vis-map-graph' of git…

a2a3e9a

…hub.com:sebelga/kibana into table-list-view/integrate-package-vis-map-graph

Add kibana.jsonc

cb1e243

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

5697063

Merge branch 'table-list-view/enhance-ux' into table-list-view/integr…

42421b3

…ate-package-vis-map-graph

Merge branch 'table-list-view/enhance-ux' into table-list-view/integr…

4a030f7

…ate-package-vis-map-graph

sebelga merged commit b236f9c into elastic:table-list-view/enhance-ux Sep 14, 2022

sebelga deleted the table-list-view/integrate-package-vis-map-graph branch September 14, 2022 07:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Table list view] Integrate package into visualizations, maps, graphs #140040

[Table list view] Integrate package into visualizations, maps, graphs #140040

sebelga commented Sep 5, 2022 •

edited

Loading

ThomThomson left a comment

rshen91 Sep 6, 2022

sebelga Sep 7, 2022

sebelga Sep 7, 2022

rshen91 Sep 6, 2022

sebelga Sep 7, 2022

flash1293 left a comment

sebelga commented Sep 8, 2022

sebelga commented Sep 8, 2022

sebelga commented Sep 8, 2022 •

edited

Loading

flash1293 commented Sep 12, 2022

sebelga commented Sep 13, 2022

sebelga commented Sep 13, 2022

sebelga commented Sep 13, 2022

sebelga commented Sep 13, 2022

kibana-ci commented Sep 13, 2022 •

edited

Loading

[Table list view] Integrate package into visualizations, maps, graphs #140040

[Table list view] Integrate package into visualizations, maps, graphs #140040

Conversation

sebelga commented Sep 5, 2022 • edited Loading

How to test

Edit

ThomThomson left a comment

Choose a reason for hiding this comment

rshen91 Sep 6, 2022

Choose a reason for hiding this comment

sebelga Sep 7, 2022

Choose a reason for hiding this comment

sebelga Sep 7, 2022

Choose a reason for hiding this comment

rshen91 Sep 6, 2022

Choose a reason for hiding this comment

sebelga Sep 7, 2022

Choose a reason for hiding this comment

flash1293 left a comment

Choose a reason for hiding this comment

sebelga commented Sep 8, 2022

sebelga commented Sep 8, 2022

sebelga commented Sep 8, 2022 • edited Loading

flash1293 commented Sep 12, 2022

sebelga commented Sep 13, 2022

sebelga commented Sep 13, 2022

sebelga commented Sep 13, 2022

sebelga commented Sep 13, 2022

kibana-ci commented Sep 13, 2022 • edited Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

History

sebelga commented Sep 5, 2022 •

edited

Loading

sebelga commented Sep 8, 2022 •

edited

Loading

kibana-ci commented Sep 13, 2022 •

edited

Loading