-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens][Agg based] Fix table pagination bug for both lens and agg based #139160
Conversation
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested—works great.
It seems like we are just a few hours too late for 8.4.0, let’s wait until early next week to merge it and release it with 8.4.1 |
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
elastic#139160) (cherry picked from commit 90f2c80)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
#139160) (#139330) (cherry picked from commit 90f2c80) Co-authored-by: Joe Reuter <[email protected]>
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
…g based (#139160) (#139393) * [Lens][Agg based] Fix table pagination bug for both lens and agg based (#139160) (cherry picked from commit 90f2c80) * resolve type issue Co-authored-by: Joe Reuter <[email protected]> Co-authored-by: Andrew Tate <[email protected]>
Fixes #139126
There were two problems working together to cause this issue:
This PR is doing two things:
The second point can't happen on filter click because the number of rows can shrink due to a large number of different causes (basically everything that triggers a new data load, e.g. hitting refresh, auto-refresh, changing time range, changing the query, ...)
Kapture.2022-08-19.at.11.26.30.mp4