[Uptime] Fix: Adjust tooltip on Run test button for Private Locations #138863

awahab07 · 2022-08-16T00:26:28Z

Summary

On Uptime -> Monitor Management -> Add Monitor page, Ru test is disabled if only Private Locations are selected without a tooltip. This PR adds a tooltip for this case.

If Add Monitor form is all in valid state and only Private Locations are selected, Run test will be disabled with the following tooltip:

Note that the tooltip content is the same as shown on Uptime -> Monitors page for monitors with only Private Locations.

Note that since we cannot use EuiTooltip because of the scroll issue, A workaround was needed to make EuiPopover be able to be shown on a disabled button. The PR uses onMouseOver and onMouseOut instead of onMouseEnter and onMouseLeave to achieve this.

Additional Enhancements
The PR also adds a tooltip when the test is in-progress and Run test is disabled. It's the same tooltip that is shown on Uptime -> Monitors page when on-demand test is in progress. (see below screenshot)

Additional Fixes
In Addition to the above, the PR fixes the behavior where Run test was running tests on all selected location (both public and private). After the fix, Run test will only run the on-demand test on public locations. (see below screenshot)

elasticmachine · 2022-08-16T00:26:30Z

Pinging @elastic/uptime (Team:uptime)

dominiqueclarke · 2022-08-16T22:53:38Z

...gins/synthetics/public/legacy_uptime/components/monitor_management/action_bar/action_bar.tsx

+
+            <EuiToolTip
+              position="top"
+              content={<p>Works on any kind of element &mdash; buttons, inputs, you name it!</p>}


What content is this supposed to have?

Looking at this further, I think this whole code block isn't supposed to be here.

dominiqueclarke · 2022-08-16T22:56:09Z

x-pack/plugins/synthetics/public/legacy_uptime/components/overview/monitor_list/translations.ts

+export const PRIVATE_AVAILABLE_LABEL = i18n.translate(
+  'xpack.synthetics.monitorList.testNow.available.private',
+  {
+    defaultMessage: `You can't currently test monitors running on private locations on demand.`,


Suggested change

defaultMessage: `You can't currently test monitors running on private locations on demand.`,

defaultMessage: `Test now is currently not available for monitors running on private locations`,

The copy comes from here #137912 (comment).

dominiqueclarke · 2022-08-16T22:56:21Z

x-pack/plugins/synthetics/public/legacy_uptime/components/overview/monitor_list/translations.ts

+export const TEST_NOW_ARIA_LABEL = i18n.translate(
+  'xpack.synthetics.monitorList.testNow.AriaLabel',
+  {
+    defaultMessage: 'CLick to run test now',


Suggested change

defaultMessage: 'CLick to run test now',

defaultMessage: 'Click to run test now',

dominiqueclarke · 2022-08-16T22:58:53Z

...gins/synthetics/public/legacy_uptime/components/monitor_management/action_bar/action_bar.tsx

+            <EuiToolTip
+              position="top"
+              content={<p>Works on any kind of element &mdash; buttons, inputs, you name it!</p>}
+            >
+              <EuiButton disabled={true} onClick={() => {}}>
+                Hover me
+              </EuiButton>
+            </EuiToolTip>


Suggested change

<EuiToolTip

position="top"

content={<p>Works on any kind of element — buttons, inputs, you name it!</p>}

>

<EuiButton disabled={true} onClick={() => {}}>

Hover me

</EuiButton>

</EuiToolTip>

Oops! Checked-in the example piece. Thanks for spotting.

dominiqueclarke · 2022-08-16T23:59:14Z

...gins/synthetics/public/legacy_uptime/components/monitor_management/action_bar/action_bar.tsx

            {onTestNow && (
              <EuiFlexItem grow={false}>
                {/* Popover is used instead of EuiTooltip until the resolution of https://github.com/elastic/eui/issues/5604 */}
                <EuiPopover
                  repositionOnScroll={true}
+                  ownFocus={false}
+                  initialFocus={''}


What does this do when a value isn't specified?

Here we don't want the popover to capture focus when it's opened, to behave like a tooltip. Providing an empty selector is the only option as undefined is the default value.

Without specifying the prop, it focuses the popover, stealing the focus from monitor form.

awahab07 · 2022-08-17T15:44:01Z

@dominiqueclarke the suggested changes are ready.

…popover on a disabled button.

awahab07 · 2022-08-18T14:49:06Z

@elasticmachine merge upstream

…e-locations

…-run-test-for-on-private-locations

…e-locations

awahab07 · 2022-08-22T09:56:08Z

@elasticmachine merge upstream

…e-locations

dominiqueclarke · 2022-08-22T19:49:57Z

LGTM generally, but I wonder about one thing.

On prem, before selecting a location, the test now button still displays information about test now. Only when you add a location do you realize you can't actually use test now. I think that for on-prem, we should display that you cannot use test now immediately.

…oltip-on-run-test-for-on-private-locations

…e-locations

dominiqueclarke

LGTM

…e-locations

awahab07 · 2022-09-21T12:25:16Z

@elasticmachine merge upstream

…e-locations

kibana-ci · 2022-09-21T13:25:16Z

💚 Build Succeeded

Buildkite Build
Commit: 69fce5c

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`synthetics`	992.7KB	993.1KB	+399.0B

History

💚 Build #72606 succeeded 6387ad0
💚 Build #66772 succeeded 3d255ca
💛 Build #66750 was flaky 9b310c2
💚 Build #66325 succeeded 13de910
💛 Build #66096 was flaky 2fce195
💔 Build #66058 failed 9ca9c7c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2022-09-21T13:33:28Z

💔 All backports failed

Status	Branch	Result
❌	8.4	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 138863

Questions ?

Please refer to the Backport tool documentation

kibanamachine · 2022-09-23T13:31:43Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 138863 locally

kibanamachine · 2022-09-26T13:41:42Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 138863 locally

awahab07 · 2022-09-26T14:03:29Z

💚 All backports created successfully

Status	Branch	Result
✅	8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…elastic#138863) * Control popover logic with MouseOver and MouseOut to be able to show popover on a disabled button. * Run "Test now" only on public locations. * Show specific tooltip when only private locations are available. (cherry picked from commit f3331b9) # Conflicts: # x-pack/plugins/synthetics/public/legacy_uptime/components/monitor_management/action_bar/action_bar.tsx

…#138863) (#141778) * Control popover logic with MouseOver and MouseOut to be able to show popover on a disabled button. * Run "Test now" only on public locations. * Show specific tooltip when only private locations are available. (cherry picked from commit f3331b9) # Conflicts: # x-pack/plugins/synthetics/public/legacy_uptime/components/monitor_management/action_bar/action_bar.tsx

awahab07 added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v8.4.0 v8.5.0 labels Aug 16, 2022

awahab07 requested a review from a team as a code owner August 16, 2022 00:26

dominiqueclarke reviewed Aug 16, 2022

View reviewed changes

dominiqueclarke self-requested a review August 16, 2022 22:59

dominiqueclarke reviewed Aug 16, 2022

View reviewed changes

dominiqueclarke self-requested a review August 17, 2022 01:27

awahab07 force-pushed the fix-adjust-tooltip-on-run-test-for-on-private-locations branch from 3eafdd1 to dc539d0 Compare August 17, 2022 14:10

awahab07 added 5 commits August 18, 2022 13:09

Move reusable translations up.

3b8ba62

Control popover logic with MouseOver and MouseOut to be able to show …

2909086

…popover on a disabled button.

Run "Test now" only on public locations.

109f85f

PR Feedback.

a7b9a9d

Fix.

651761a

awahab07 force-pushed the fix-adjust-tooltip-on-run-test-for-on-private-locations branch from 941a48f to 651761a Compare August 18, 2022 11:12

kibanamachine and others added 3 commits August 18, 2022 10:49

Merge branch 'main' into fix-adjust-tooltip-on-run-test-for-on-privat…

9ca9c7c

…e-locations

Merge remote-tracking branch 'origin/main' into fix-adjust-tooltip-on…

8dff2ac

…-run-test-for-on-private-locations

Merge branch 'main' into fix-adjust-tooltip-on-run-test-for-on-privat…

2fce195

…e-locations

kibanamachine and others added 2 commits August 22, 2022 05:56

Merge branch 'main' into fix-adjust-tooltip-on-run-test-for-on-privat…

13de910

…e-locations

Merge branch 'main' into fix-adjust-tooltip-on-run-test-for-on-privat…

6da8135

…e-locations

awahab07 added 2 commits August 23, 2022 15:19

Show specific tooltip when only private locations are available.

d0c22dd

Merge remote-tracking branch 'elastic-kibana/main' into fix-adjust-to…

9b310c2

…oltip-on-run-test-for-on-private-locations

Merge branch 'main' into fix-adjust-tooltip-on-run-test-for-on-privat…

3d255ca

…e-locations

dominiqueclarke approved these changes Aug 24, 2022

View reviewed changes

Merge branch 'main' into fix-adjust-tooltip-on-run-test-for-on-privat…

6387ad0

…e-locations

Merge branch 'main' into fix-adjust-tooltip-on-run-test-for-on-privat…

69fce5c

…e-locations

awahab07 merged commit f3331b9 into elastic:main Sep 21, 2022

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 23, 2022

awahab07 mentioned this pull request Sep 26, 2022

[8.4] [Uptime] Fix: Adjust tooltip on Run test button for Private Locations (#138863) #141778

Merged

kibanamachine added v8.4.3 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Sep 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Uptime] Fix: Adjust tooltip on Run test button for Private Locations #138863

[Uptime] Fix: Adjust tooltip on Run test button for Private Locations #138863

awahab07 commented Aug 16, 2022 •

edited by kibanamachine

Loading

elasticmachine commented Aug 16, 2022

dominiqueclarke Aug 16, 2022

dominiqueclarke Aug 16, 2022

dominiqueclarke Aug 16, 2022

awahab07 Aug 17, 2022

dominiqueclarke Aug 16, 2022

dominiqueclarke Aug 16, 2022

awahab07 Aug 17, 2022

dominiqueclarke Aug 16, 2022

awahab07 Aug 17, 2022 •

edited

Loading

awahab07 commented Aug 17, 2022

awahab07 commented Aug 18, 2022

awahab07 commented Aug 22, 2022

dominiqueclarke commented Aug 22, 2022

dominiqueclarke left a comment

awahab07 commented Sep 21, 2022

kibana-ci commented Sep 21, 2022

kibanamachine commented Sep 21, 2022

kibanamachine commented Sep 23, 2022

kibanamachine commented Sep 26, 2022

awahab07 commented Sep 26, 2022

	defaultMessage: `You can't currently test monitors running on private locations on demand.`,
	defaultMessage: `Test now is currently not available for monitors running on private locations`,

	defaultMessage: 'CLick to run test now',
	defaultMessage: 'Click to run test now',

[Uptime] Fix: Adjust tooltip on Run test button for Private Locations #138863

[Uptime] Fix: Adjust tooltip on Run test button for Private Locations #138863

Conversation

awahab07 commented Aug 16, 2022 • edited by kibanamachine Loading

Summary

elasticmachine commented Aug 16, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

awahab07 Aug 17, 2022 • edited Loading

Choose a reason for hiding this comment

awahab07 commented Aug 17, 2022

awahab07 commented Aug 18, 2022

awahab07 commented Aug 22, 2022

dominiqueclarke commented Aug 22, 2022

dominiqueclarke left a comment

Choose a reason for hiding this comment

awahab07 commented Sep 21, 2022

kibana-ci commented Sep 21, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

History

kibanamachine commented Sep 21, 2022

💔 All backports failed

Manual backport

Questions ?

kibanamachine commented Sep 23, 2022

kibanamachine commented Sep 26, 2022

awahab07 commented Sep 26, 2022

💚 All backports created successfully

Questions ?

awahab07 commented Aug 16, 2022 •

edited by kibanamachine

Loading

awahab07 Aug 17, 2022 •

edited

Loading