[Synthetics UI] Update copy for test now functionality on private locations #137912

justinkambic · 2022-08-02T19:54:43Z

Summary

Modifies the copy displayed on a tooltip in the application.

elasticmachine · 2022-08-02T19:54:46Z

Pinging @elastic/uptime (Team:uptime)

colleenmcginnis · 2022-08-02T22:27:51Z

...ns/synthetics/public/legacy_uptime/components/overview/monitor_list/columns/test_now_col.tsx

@@ -82,7 +82,8 @@ export const TEST_NOW_AVAILABLE_LABEL = i18n.translate(
 export const PRIVATE_AVAILABLE_LABEL = i18n.translate(
  'xpack.synthetics.monitorList.testNow.available.private',
  {
-    defaultMessage: 'For now, Test now is disabled for private locations monitors.',
+    defaultMessage:
+      'Test now is currently not available for monitors running on Private Locations.',


@justinkambic do you have a screenshot of how this is being used? My initial reaction is that Test now ... is confusing, but if this tooltip is targeting a button that says "Test now" it might be ok (or we could just say "This is not currently available for...").

@colleenmcginnis if the monitor in the list is not fleet-managed and has a valid config ID, we render a play button which will kick off the one-off test.

We render the tooltip that uses this label in the case that the monitor is fleet-managed. So if the user created the monitor with the synthetics integration, and it's being handled with elastic agent/fleet rather than the synthetics service, we're not able to test it on demand.

I don't have a screenshot of this and my env isn't configured in a way that I can easily get one, but does that explanation make sense? If a screenshot is still necessary I can see about getting one for you today.

Thanks @justinkambic. What to you think about something like this instead?

You can't currently test monitors running on private locations on demand.

@colleenmcginnis I am attaching screenshots of the three states this play (Test now) button can have. Please see if

You can't currently test monitors running on private locations on demand.

is till valid observing the context in screenshots. Also, we may need to change the copy for the other disabled state similar to this one.

When Test now is available.

When Test now is not available due to monitor running on Private Loations.

When Test now is not available due to a legacy monitor.

awahab07 · 2022-08-09T15:02:18Z

@elasticmachine merge upstream

justinkambic · 2022-08-11T15:29:14Z

...ns/synthetics/public/legacy_uptime/components/overview/monitor_list/columns/test_now_col.tsx

@@ -82,7 +82,7 @@ export const TEST_NOW_AVAILABLE_LABEL = i18n.translate(
 export const PRIVATE_AVAILABLE_LABEL = i18n.translate(
  'xpack.synthetics.monitorList.testNow.available.private',
  {
-    defaultMessage: 'For now, Test now is disabled for private locations monitors.',
+    defaultMessage: `You can't currently test monitors running on private locations on demand.`,


@colleenmcginnis LMK if you'd like to see anything else changed here.

This looks good to me if it looks good to you! 👍

justinkambic · 2022-08-12T15:55:34Z

@awahab07 @colleenmcginnis can one/both of you approve if there are no further changes needed?

awahab07 · 2022-08-13T23:57:10Z

@elasticmachine merge upstream

kibana-ci · 2022-08-15T14:30:08Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: f6b0c1c

Failed CI Steps

Jest Integration Tests #2

Test Failures

[job] [logs] Jest Integration Tests #2 / Fleet preconfiguration reset Reset all policy Works and reset all preconfigured policies
[job] [logs] Jest Integration Tests #2 / Fleet preconfiguration reset Reset one preconfigured policy Works and reset one preconfigured policies if the policy is already deleted (with a ghost package policy)
[job] [logs] Jest Integration Tests #2 / Fleet preconfiguration reset Reset one preconfigured policy Works and reset one preconfigured policies if the policy was deleted with a preconfiguration deletion record
[job] [logs] Jest Integration Tests #2 / Fleet preconfiguration reset Reset one preconfigured policy Works if the preconfigured policies already exists with a missing package policy

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`synthetics`	912.4KB	912.4KB	+12.0B

History

💔 Build #64979 failed 7f596c1a02fa164ff282453d9c7e9e67a2437004
💛 Build #64581 was flaky 91a64ba42ab9bb659d633ec9d4110dc71da69f02
💚 Build #63959 succeeded 368dd2ca4fb096d99d6e960c86c9e817d940af84
💚 Build #62583 succeeded 0283f48b543211dc3753e1acd6d9db59f48bec23

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @justinkambic

awahab07

LGTM

…ations (elastic#137912) * Update copy for test now functionality on private locations. * Update copy based on PR feedback. (cherry picked from commit e7772b1)

kibanamachine · 2022-08-15T16:15:06Z

💚 All backports created successfully

Status	Branch	Result
✅	8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…ations (elastic#137912) (elastic#138835) * Update copy for test now functionality on private locations. * Update copy based on PR feedback. (cherry picked from commit e7772b1) Co-authored-by: Justin Kambic <[email protected]>

…ations (elastic#137912) * Update copy for test now functionality on private locations. * Update copy based on PR feedback.

justinkambic added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v8.4.0 v8.5.0 labels Aug 2, 2022

justinkambic requested a review from a team as a code owner August 2, 2022 19:54

justinkambic self-assigned this Aug 2, 2022

colleenmcginnis reviewed Aug 2, 2022

View reviewed changes

justinkambic force-pushed the 137898/update-copy-for-private-locations-test-now-message branch from 368dd2c to 91a64ba Compare August 11, 2022 15:28

justinkambic commented Aug 11, 2022

View reviewed changes

justinkambic added 2 commits August 15, 2022 09:59

Update copy for test now functionality on private locations.

98cd7f6

Update copy based on PR feedback.

f6b0c1c

justinkambic force-pushed the 137898/update-copy-for-private-locations-test-now-message branch from 7f596c1 to f6b0c1c Compare August 15, 2022 13:59

awahab07 approved these changes Aug 15, 2022

View reviewed changes

justinkambic merged commit e7772b1 into elastic:main Aug 15, 2022

justinkambic deleted the 137898/update-copy-for-private-locations-test-now-message branch August 15, 2022 16:11

kibanamachine mentioned this pull request Aug 15, 2022

[8.4] [Synthetics UI] Update copy for test now functionality on private locations (#137912) #138835

Merged

awahab07 mentioned this pull request Aug 17, 2022

[Uptime] Fix: Adjust tooltip on Run test button for Private Locations #138863

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Synthetics UI] Update copy for test now functionality on private locations #137912

[Synthetics UI] Update copy for test now functionality on private locations #137912

justinkambic commented Aug 2, 2022 •

edited by kibanamachine

Loading

elasticmachine commented Aug 2, 2022

colleenmcginnis Aug 2, 2022

justinkambic Aug 4, 2022 •

edited

Loading

colleenmcginnis Aug 9, 2022

awahab07 Aug 10, 2022

awahab07 commented Aug 9, 2022

justinkambic Aug 11, 2022

colleenmcginnis Aug 11, 2022

justinkambic commented Aug 12, 2022

awahab07 commented Aug 13, 2022

kibana-ci commented Aug 15, 2022 •

edited

Loading

awahab07 left a comment

kibanamachine commented Aug 15, 2022

[Synthetics UI] Update copy for test now functionality on private locations #137912

[Synthetics UI] Update copy for test now functionality on private locations #137912

Conversation

justinkambic commented Aug 2, 2022 • edited by kibanamachine Loading

Summary

elasticmachine commented Aug 2, 2022

colleenmcginnis Aug 2, 2022

Choose a reason for hiding this comment

justinkambic Aug 4, 2022 • edited Loading

Choose a reason for hiding this comment

colleenmcginnis Aug 9, 2022

Choose a reason for hiding this comment

awahab07 Aug 10, 2022

Choose a reason for hiding this comment

awahab07 commented Aug 9, 2022

justinkambic Aug 11, 2022

Choose a reason for hiding this comment

colleenmcginnis Aug 11, 2022

Choose a reason for hiding this comment

justinkambic commented Aug 12, 2022

awahab07 commented Aug 13, 2022

kibana-ci commented Aug 15, 2022 • edited Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

History

awahab07 left a comment

Choose a reason for hiding this comment

kibanamachine commented Aug 15, 2022

💚 All backports created successfully

Questions ?

justinkambic commented Aug 2, 2022 •

edited by kibanamachine

Loading

justinkambic Aug 4, 2022 •

edited

Loading

kibana-ci commented Aug 15, 2022 •

edited

Loading