-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Incorporate point series design guidelines #13847
Conversation
I checked this out again today and still ran into the same problem where the graphs weren't building against this branch for me. Might be unrelated, haven't run master kibana in a bit. Though I do see this error in console
The only place I could see it in action was on discovery... Looks like the text size changed, and i see the background ticks, but the colors for the text are still coming from the old set. |
7b3cb38
to
86cc9c6
Compare
changed styling for timelion as well: here's a comparison: much of the difference is in the layouting of the chart-elements (title, legend, ...). Aligning those would be out of scope for here AFAIC. Timelion is also a little more complicated, since the yaxes data model doesn't entirely map to that of Visualize. So we'll have to chew a little on the implementation. |
the only difference on the base chart level that i see (so ignoring the titles, legends) is
|
Since there is already an ongoing effort of creating a unified charting component in EUI (elastic/eui#309), that will hopefully replace all chart implementations in the short or mid-term, I think we should not spend much more effort in this PR. If you agree, please feel free to close it. |
💔 Build Failed |
Reopening #13662 against feature branch.
implements #13335 for visualize point series charts