Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Incorporate point series design guidelines #13847

Closed
wants to merge 7 commits into from

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Sep 5, 2017

Reopening #13662 against feature branch.

implements #13335 for visualize point series charts

@thomasneirynck thomasneirynck added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v6.0.0 v6.1.0 v7.0.0 labels Sep 5, 2017
@snide
Copy link
Contributor

snide commented Sep 11, 2017

I checked this out again today and still ran into the same problem where the graphs weren't building against this branch for me. Might be unrelated, haven't run master kibana in a bit.

Though I do see this error in console

Uncaught (in promise) TypeError: axis.getScale(...).ticks is not a function

image

The only place I could see it in action was on discovery...

image

Looks like the text size changed, and i see the background ticks, but the colors for the text are still coming from the old set.

@thomasneirynck thomasneirynck force-pushed the feature/visualize_design branch from 7b3cb38 to 86cc9c6 Compare October 5, 2017 16:18
@thomasneirynck
Copy link
Contributor Author

thomasneirynck commented Oct 5, 2017

changed styling for timelion as well:

here's a comparison:

image

much of the difference is in the layouting of the chart-elements (title, legend, ...). Aligning those would be out of scope for here AFAIC.

Timelion is also a little more complicated, since the yaxes data model doesn't entirely map to that of Visualize. So we'll have to chew a little on the implementation.

@thomasneirynck thomasneirynck requested a review from snide October 5, 2017 22:26
@thomasneirynck thomasneirynck changed the title Incorporate point series design guidelines [WIP] Incorporate point series design guidelines Oct 5, 2017
@thomasneirynck thomasneirynck added the WIP Work in progress label Oct 5, 2017
@ppisljar
Copy link
Member

ppisljar commented Oct 6, 2017

the only difference on the base chart level that i see (so ignoring the titles, legends) is

  • the grid ... in visualize its thicker ...
  • x axis labels .... in visualize they get cut off ?

@timroes
Copy link
Contributor

timroes commented Mar 9, 2018

Since there is already an ongoing effort of creating a unified charting component in EUI (elastic/eui#309), that will hopefully replace all chart implementations in the short or mid-term, I think we should not spend much more effort in this PR. If you agree, please feel free to close it.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@spalger spalger deleted the feature/visualize_design branch May 2, 2018 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v6.2.3 v7.0.0 WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants