-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating based on design guidelines #13662
Conversation
jenkins, test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooh nice..
We should change following defaults as well:
- in the
Panel Settings
- X-axis lines to
true
- Y-axis lines to first axis (ie.
LeftAxis-1
)
- X-axis lines to
- in the
Metrics & Axes
- default Show Circles to
false
- default Show Circles to
I would also change the styling of the ticks to use px
iso pt
. The problem with this is that Flot, used in TSVB requires pixels sizes. It will be easily to ensure Timelion and TSVB look identical to Visualize-charts if we use px sizing (https://github.com/thomasneirynck/kibana/blob/475e0e71a58691f6a1638ce4e255e5b7e4c7695e/src/ui/public/vislib/lib/axis/axis_config.js#L40-L40). Similar to if ever other charting-libraries get introduced.
I would create feature branch for this effort in the Kibana-repo so multiple people can commit on it. We need to do this for Timelion and TSVB as well, and can distribute work for that. We'll also need to extract these configurations to a separate module, so other plugins (watcher and montioring in particular) will be able to read from it (although that is longer term issues).
475e0e7
to
6f75fb4
Compare
thanks Thomas, i updated based on your review. |
tests are failing due to less axis labels being displayed as we increased the font size. |
closing in favor of same PR against feature branch. this will allow us to easier collaborate on getting similar changes for timelion and tsvb in there. #13847. |
implements #13335 for visualize point series charts