Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA][Code Coverage] exclude broken jest integration suites #137987

Closed
wants to merge 5 commits into from

Conversation

wayneseymour
Copy link
Member

@wayneseymour wayneseymour commented Aug 3, 2022

Summary

Excluding failing suites, after noticing they were breaking code coverage.
These jest integration suites dont allow the jest-integration portion to complete, so ingestion never starts.

Code Coverage Ingestion cannot start: #138426

@wayneseymour wayneseymour self-assigned this Aug 3, 2022
@wayneseymour
Copy link
Member Author

@wayneseymour
Copy link
Member Author

@wayneseymour wayneseymour changed the title [QA][Code Coverage] Skip failing suite [QA][Code Coverage] exclude broken jest integration suite Aug 4, 2022
@wayneseymour wayneseymour changed the title [QA][Code Coverage] exclude broken jest integration suite [QA][Code Coverage] exclude broken jest integration suites Aug 4, 2022
@wayneseymour wayneseymour requested a review from LeeDr August 12, 2022 15:35
@wayneseymour wayneseymour marked this pull request as ready for review August 12, 2022 15:35
@wayneseymour wayneseymour requested a review from a team as a code owner August 12, 2022 15:35
@wayneseymour wayneseymour removed the request for review from LeeDr August 12, 2022 15:43
@pgayvallet
Copy link
Contributor

@wayneseymour could we get more details on that issue? I don't really like the idea of disabling some of our integration tests 'just' because there is an issue with the code coverage tool around them. Isn't there another way to address that problem?

@wayneseymour
Copy link
Member Author

@wayneseymour could we get more details on that issue? I don't really like the idea of disabling some of our integration tests 'just' because there is an issue with the code coverage tool around them. Isn't there another way to address that problem?

Yeah I could understand that. From my perspective, it just "started happening".

IIRC, it happened right after this landed:
#136539

@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@wayneseymour
Copy link
Member Author

@pgayvallet
Copy link
Contributor

Seems green now?

@wayneseymour
Copy link
Member Author

Seems green now?

kinda lol:

Screenshot 2022-08-24 at 14 12 15

@wayneseymour
Copy link
Member Author

@wayneseymour could we get more details on that issue? I don't really like the idea of disabling some of our integration tests 'just' because there is an issue with the code coverage tool around them. Isn't there another way to address that problem?

Fwiw, I concur with you about disabling them just because of cc.

@pgayvallet
Copy link
Contributor

Problem should be addressed by #139636

@sophiec20 sophiec20 deleted the cc/exclude-broken-jest-integration-suite branch July 29, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment