-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split core's server-side integration tests into multiple suites #136539
Split core's server-side integration tests into multiple suites #136539
Conversation
Pinging @elastic/kibana-core (Team:Core) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
I wish we could do something similar for the functional tests.
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Very interesting PR! 👏🏼 I’ve checked some CI builds before and after the PR and it seems that have some re-arrangement of the workload in the 2 CI jobs for integration tests: Before
After
It seems that overall the 2 “nodes / jobs / runners / tasks” are more balanced, so if I understood correctly we reduced ~10 minutes from the overall time for Integration tests. |
Yea, that was precisely the intent, to allow CI to dispatch the IT suites properly, which was not possible previously because all our IT tests were included in the same single suite. |
Summary
Given we will have to move the integration tests to their own packages at some point anyway, this PR extract them from their current domain folder and move them to
src/core/server/integration_tests/{domain}
.Each domain now has its dedicated integration test config (
jest.integration.config.js
), which will allow CI to run them independently, therefor increasing the overall CI IT run performances.In addition, that allow to get rid of the domain folders that were still present in
src/core/server
just because there was a remainingintegration_tests
folder in it.