Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split core's server-side integration tests into multiple suites #136539

Merged
merged 9 commits into from
Jul 20, 2022

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Jul 18, 2022

Summary

Given we will have to move the integration tests to their own packages at some point anyway, this PR extract them from their current domain folder and move them to src/core/server/integration_tests/{domain}.

Each domain now has its dedicated integration test config (jest.integration.config.js), which will allow CI to run them independently, therefor increasing the overall CI IT run performances.

In addition, that allow to get rid of the domain folders that were still present in src/core/server just because there was a remaining integration_tests folder in it.

@pgayvallet pgayvallet added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes v8.4.0 labels Jul 18, 2022
@pgayvallet pgayvallet marked this pull request as ready for review July 19, 2022 08:29
@pgayvallet pgayvallet requested a review from a team as a code owner July 19, 2022 08:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
I wish we could do something similar for the functional tests.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit 5aad18f into elastic:main Jul 20, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 20, 2022
@gsoldevila
Copy link
Contributor

gsoldevila commented Jul 25, 2022

Very interesting PR! 👏🏼

I’ve checked some CI builds before and after the PR and it seems that have some re-arrangement of the workload in the 2 CI jobs for integration tests:

Before

  • Jest Integration #1: 25-28m
  • Jest Integration #2: 45-48m

After

  • Jest Integration #1: 35-37m
  • Jest Integration #2: 35-37m

It seems that overall the 2 “nodes / jobs / runners / tasks” are more balanced, so if I understood correctly we reduced ~10 minutes from the overall time for Integration tests.

@pgayvallet
Copy link
Contributor Author

It seems that overall the 2 “nodes / jobs / runners / tasks” are more balanced

Yea, that was precisely the intent, to allow CI to dispatch the IT suites properly, which was not possible previously because all our IT tests were included in the same single suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants