Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified search] Make resizable button as the EUI one #137698

Merged
merged 13 commits into from
Aug 9, 2022

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Aug 1, 2022

Summary

Part of #136950

Make the custom resizable button to look and feel like the EUIResizableButton (not exported by EUI).

uni1

@stratoula stratoula added Feature:Unified search Unified search related tasks v8.5.0 Team:AppServicesSv release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Aug 1, 2022
@stratoula stratoula marked this pull request as ready for review August 1, 2022 14:18
@stratoula stratoula requested review from a team as code owners August 1, 2022 14:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@stratoula
Copy link
Contributor Author

@MichaelMarcialis I think I managed to move the styles from eui to our editor. 🤞

Copy link
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, @stratoula! Thanks so much for putting this together. I've left some comments below for your review.

Would it be possible to move the resizable button so that it appears on top of the border that divides the unified search UI and the rest of the page content (see example GIF below)? I think doing so would be a nice touch.

resize

@cchaos
Copy link
Contributor

cchaos commented Aug 2, 2022

My walking away piece of advice:

Don't copy/paste direct EUI styles/code. Ask EUI to export this button at the top level: https://github.com/elastic/eui/blob/main/src/components/resizable_container/resizable_button.tsx

It'll keep in sync with any a11y or style changes and you can request general improvements that will benefit all usages. 😸

@stratoula
Copy link
Contributor Author

Yes @cchaos you are right. I created an issue here elastic/eui#6100
@MichaelMarcialis does it make sense to wait for EUI team to respond on my request and continue with this PR depending on the decision?

@MichaelMarcialis
Copy link
Contributor

Yes @cchaos you are right. I created an issue here elastic/eui#6100
@MichaelMarcialis does it make sense to wait for EUI team to respond on my request and continue with this PR depending on the decision?

Thanks for that advice, @cchaos. @stratoula, since you've already done the work here, I say going ahead with this PR and then switching when EUI exports the button makes sense to me. The issue you created will remind us not to forget to make the switch.

@stratoula
Copy link
Contributor Author

@MichaelMarcialis I think I addressed everything!
uni1

Copy link
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates, @stratoula. Leaving you a few additional comments below for your review.

Also, I noticed that in expanded mode the space between editor footer and border is smaller than the space space between border and page content. On initial glance, it looks like this might be happening because of the negative margining that exists on the editor footer's EuiFlexGroup. Would it be possible to fix this issue so that the space between both areas is equal (8px from border)?

image

Copy link
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @stratoula. I've opened a quick design PR for this branch. Once that gets merged in, this looks good from my perspective. Approving now so I don't hold you up further. Thanks!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
unifiedSearch 220 226 +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedSearch 228.1KB 232.6KB +4.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test locally, but code changes LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Unified search Unified search related tasks release_note:skip Skip the PR/issue when compiling release notes v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants