Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export the EuiResizable button #6100

Closed
stratoula opened this issue Aug 3, 2022 · 4 comments · Fixed by #7087
Closed

Export the EuiResizable button #6100

stratoula opened this issue Aug 3, 2022 · 4 comments · Fixed by #7087
Assignees

Comments

@stratoula
Copy link
Contributor

We have a case where we can't use the ResizableContainer. Check the comment here elastic/kibana#136702 (comment). We need to make many changes on how the unified search component is used across kibana.

We have created our custom solution that works fine but we would like to use the resizable button, in order to not copy paste styles from EUI to kibana.
elastic/kibana#137698 (comment)

@chandlerprall
Copy link
Contributor

After the flyout is converted to emotion (currently in progress) we will be picking up #287 which allows resizing a flyout. This will internally reuse EuiResizableButton and we'll be able to verify it works well on its own, outside of the resizable container, and I think makes the most sense to wait until then to export so we ensure it works as expected.

We talked over zoom about the timeline for this, and unless anyone else disagrees we decided the unified search implementation can wait until we do the flyout work.

@github-actions
Copy link

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

@cee-chen
Copy link
Contributor

@stratoula The generic EuiResizableButton will be available in EUI's release next Tuesday and then in Kibana main a little after that (so a week or so more of time). Example usage: https://eui.elastic.co/pr_7087/#/layout/resizable-container#custom-resizable-button

@stratoula
Copy link
Contributor Author

@cee-chen thanx, this is awesome!

@cee-chen cee-chen self-assigned this Aug 17, 2023
stratoula added a commit to elastic/kibana that referenced this issue Sep 8, 2023
## Summary

When I created the text based editor, the resizable button was not
exported from EUI so I had to create my own custom solution. It was
recently been exported and merged in kibana so now we can remove the
custom solution and use the EUI component instead!

elastic/eui#6100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants