Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Exceptions] - Fix scroll on edit exception flyout #137492

Merged
merged 7 commits into from
Aug 3, 2022
Merged

[Security Solution][Exceptions] - Fix scroll on edit exception flyout #137492

merged 7 commits into from
Aug 3, 2022

Conversation

yctercero
Copy link
Contributor

Summary

Addresses issue #136942 - when editing exception items with numerous entries, flyout was not scrolling properly.

scroll_fix.mov

Checklist

@yctercero yctercero added release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed Team:Security Solution Platform Security Solution Platform Team ci:deploy-cloud v8.4.0 v8.5.0 labels Jul 28, 2022
@yctercero yctercero requested a review from a team as a code owner July 28, 2022 16:18
@yctercero yctercero self-assigned this Jul 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@yctercero yctercero enabled auto-merge (squash) July 28, 2022 16:28
@yctercero
Copy link
Contributor Author

@elasticmachine merge upstream

@yctercero
Copy link
Contributor Author

@elasticmachine merge upstream

@yctercero
Copy link
Contributor Author

@elasticmachine merge upstream

@yctercero
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

expected head sha didn’t match current head ref.

@yctercero
Copy link
Contributor Author

@elasticmachine merge upstream

1 similar comment
@MadameSheema
Copy link
Member

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 5.6MB 5.6MB -6.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

@yctercero yctercero merged commit 8e002ce into elastic:main Aug 3, 2022
@kibanamachine kibanamachine mentioned this pull request Aug 3, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Aug 3, 2022
@yctercero
[Security Solution][Exceptions] - Fix scroll on edit exception flyout (…
e945e36 
…#137492)

## Summary

Addresses issue #136942 - when editing exception items with numerous entries, flyout was not scrolling properly.

(cherry picked from commit 8e002ce)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

kibanamachine added a commit that referenced this pull request Aug 3, 2022
@kibanamachine @yctercero
[Security Solution][Exceptions] - Fix scroll on edit exception flyout (…
a909f16 
…#137492) (#138031)

## Summary

Addresses issue #136942 - when editing exception items with numerous entries, flyout was not scrolling properly.

(cherry picked from commit 8e002ce)

Co-authored-by: Yara Tercero <[email protected]>
@logeekal logeekal mentioned this pull request Aug 4, 2022
Merged
@yctercero yctercero deleted the fix_exception_flyout_scroll branch August 4, 2022 18:30
@logeekal logeekal mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley14 dhurley14 dhurley14 approved these changes

Assignees

@yctercero yctercero

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.4.0 v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yctercero @elasticmachine @kibanamachine @MadameSheema @kibana-ci @dhurley14