New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FirstLastSeen to use useSearchStrategy #137171

Merged

machadoum merged 1 commit into elastic:main from machadoum:firstLastSeen-useSearchStrategy

Jul 26, 2022

Member

machadoum commented Jul 26, 2022 •

edited by kibanamachine

Loading

Summary

Refactor FirstLastSeen to use useSearchStrategy.

Affected pages: Host details, User details, and Network details.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

machadoum force-pushed the firstLastSeen-useSearchStrategy branch from a62d1b4 to 7d6e844 Compare

July 26, 2022 12:05

machadoum self-assigned this

machadoum added Team: SecuritySolution Team:Threat Hunting:Explore Team:Threat Hunting v8.5.0 release_note:skip labels


          Refactor FirstLastSeen to use useSearchStrategy

69d31e8

machadoum force-pushed the firstLastSeen-useSearchStrategy branch from 7d6e844 to 69d31e8 Compare

July 26, 2022 12:12

machadoum marked this pull request as ready for review

July 26, 2022 12:12

machadoum requested a review from a team as a code owner

July 26, 2022 12:12

Contributor

elasticmachine commented Jul 26, 2022

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

Contributor

elasticmachine commented Jul 26, 2022

Pinging @elastic/security-solution (Team: SecuritySolution)

angorayc approved these changes

View reviewed changes

Contributor

angorayc commented Jul 26, 2022

Thanks for the enhancement @machadoum LGTM!

machadoum mentioned this pull request

Migrate explore team API calls to useSearchStrategy. #129054

Closed

Collaborator

kibana-ci commented Jul 26, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	5.5MB	5.5MB	-1.6KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

machadoum merged commit bb6c3bd into elastic:main

kibanamachine added the v8.4.0 label

Contributor

kibanamachine commented Jul 26, 2022

💔 All backports failed

Status	Branch	Result
❌	8.5	The branch "8.5" does not exist

Manual backport

To create the backport manually run:

node scripts/backport --pr 137171

Questions ?

Please refer to the Backport tool documentation

Contributor

kibanamachine commented Jul 27, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

kibanamachine added the backport missing label

Contributor

kibanamachine commented Jul 28, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

4 similar comments

Contributor

kibanamachine commented Jul 29, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Aug 1, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Aug 2, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Aug 3, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

machadoum removed the v8.5.0 label

Contributor

kibanamachine commented Aug 5, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

1 similar comment

Contributor

kibanamachine commented Aug 8, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Aug 31, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

6 similar comments

Contributor

kibanamachine commented Sep 1, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Sep 2, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Sep 5, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Sep 6, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Sep 7, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Sep 8, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

machadoum removed the v8.4.0 label

Contributor

kibanamachine commented Sep 9, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

16 similar comments

Contributor

kibanamachine commented Sep 12, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Sep 13, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Sep 14, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Sep 15, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Sep 16, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Sep 19, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Sep 20, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Sep 21, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Sep 22, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Sep 23, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Sep 26, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Sep 27, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Sep 28, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Sep 29, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Sep 30, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

kibanamachine commented Oct 3, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 137171 locally

Contributor

rylnd commented Oct 3, 2022

@machadoum this PR no longer has any version labels so it's not clear where it was merged/backported. Can you please add the appropriate labels, add any missing backports, and silence the bot?

machadoum added backport:skip and removed backport missing labels

Member Author

machadoum commented Oct 4, 2022 •

edited

Loading

It is a refactor and it was merged to master and not backported. So I added backport:skip tag to shut the bot.

machadoum added the v8.4.0 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip release_note:skip Team: SecuritySolution Team:Threat Hunting:Explore Team:Threat Hunting v8.4.0