Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate explore team API calls to useSearchStrategy. #129054

Closed
machadoum opened this issue Mar 31, 2022 · 6 comments
Closed

Migrate explore team API calls to useSearchStrategy. #129054

machadoum opened this issue Mar 31, 2022 · 6 comments
Assignees
Labels
Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team technical debt Improvement of the software architecture and operational architecture

Comments

@machadoum
Copy link
Member

machadoum commented Mar 31, 2022

Convert existing explore team API calls to useSearchStrategybecause of issue #132703 .
This ticket includes users, hosts, network, and overview pages.
We don't need to migrate KPIs because they will get converted into Lens visualizations.

This won't have any UI changes, we just need to make sure each component is rendered correctly on the page.
More verification details can be found in each PR listed below.

Files to migrate:
security_solution/public/common/containers/authentications/index.tsx - #136269
security_solution/public/hosts/containers/hosts/index.tsx - #135668
security_solution/public/hosts/containers/hosts/details/index.tsx - #135860
security_solution/public/hosts/containers/hosts/first_last_seen/index.tsx #137171
security_solution/public/hosts/containers/uncommon_processes/index.tsx - #135856
security_solution/public/network/containers/details/index.tsx - #135995
security_solution/public/network/containers/network_dns/index.tsx - #136005
security_solution/public/network/containers/network_http/index.tsx - #136115
security_solution/public/network/containers/network_top_countries/index.tsx - #136120
security_solution/public/network/containers/network_top_n_flow/index.tsx - #136143
security_solution/public/network/containers/tls/index.tsx - #136187
security_solution/public/network/containers/users/index.tsx - #136204
security_solution/public/overview/containers/overview_host/index.tsx - #136206
security_solution/public/overview/containers/overview_network/index.tsx - #136212
security_solution/public/users/containers/users/details/index.tsx - #136216
x-pack/plugins/security_solution/public/risk_score/containers/all/index.tsx

@machadoum machadoum added technical debt Improvement of the software architecture and operational architecture Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore labels Mar 31, 2022
@machadoum machadoum self-assigned this Mar 31, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@stephmilovic
Copy link
Contributor

useSearchStrategy should use rtk query, having it observable based will have the same performance problems as we saw in 8.2.1

@machadoum
Copy link
Member Author

We have addressed the performance issue on use_observable here: #132703

@semd
Copy link
Contributor

semd commented Aug 22, 2022

I added security_solution/public/common/containers/matrix_histogram/index.ts to the list. The APM performance monitoring is being implemented in the useSearchStrategy hook, so it would be nice to migrate the histograms to track them as well.

@angorayc angorayc closed this as completed Sep 7, 2022
@semd
Copy link
Contributor

semd commented Sep 14, 2022

@angorayc Will the useMatrixHistogram be migrated in another issue? Or why has it been removed from the description list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

5 participants