-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring network TLS to use useSearchStrategy #136187
Conversation
@elasticmachine merge upstream |
@elasticmachine merge upstream |
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
factoryQueryType: NetworkQueries.tls, | ||
initialResult: { | ||
edges: [], | ||
totalCount: -1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is what was there before but find it a little odd. It's not related to your PR, but i think we should set this to 0. and change code elsewhere that would be problematic because of that.
In public/common/components/paginated_table/index.tsx we have
const pageCount = Math.ceil(totalCount / limit);
which is why I think we have a -1
as default as otherwise, if it were 0 this calculation would equal Infinity. But we could change the code here to be `totalCount ? totalCount / limit : 1, or some such equivolent.
Maybe there is another reason though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ to the suggestion above. At least we need some explanation in the code why it is -1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think it's to differentiate the initial value and the fetched value and avoid the calculation error. I'll create an issue to review all the places that have this implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Screen.Recording.2022-07-18.at.11.00.40.mov
auditbeat
index pattern in the Kibana)Checklist
Delete any items that are not applicable to this PR.