-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] Add error handling for private locations #137115
Merged
dominiqueclarke
merged 8 commits into
elastic:main
from
dominiqueclarke:feature/synthetics-private-node-error-handling
Jul 26, 2022
Merged
[Synthetics] Add error handling for private locations #137115
dominiqueclarke
merged 8 commits into
elastic:main
from
dominiqueclarke:feature/synthetics-private-node-error-handling
Jul 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiqueclarke
changed the title
add error handling for private locations
[Synthetics] Add error handling for private locations
Jul 26, 2022
dominiqueclarke
added
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
enhancement
New value added to drive a business result
release_note:skip
Skip the PR/issue when compiling release notes
backport:skip
This commit does not require backporting
labels
Jul 26, 2022
Pinging @elastic/uptime (Team:uptime) |
@elasticmachine merge upstream |
shahzad31
approved these changes
Jul 26, 2022
…s://github.com/dominiqueclarke/kibana into feature/synthetics-private-node-error-handling
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
dominiqueclarke
deleted the
feature/synthetics-private-node-error-handling
branch
July 26, 2022 20:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
enhancement
New value added to drive a business result
release_note:skip
Skip the PR/issue when compiling release notes
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
v8.4.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to elastic/uptime#475
Adds better error handling for synthetics private locations.
When adding a monitor
Ensures that when downstream actions related to private locations fail, the monitor saved object does not save
When editing a monitor
Ensures that when downstream actions related to private locations fail, the monitor is not updated
When deleting a monitor
Ensures that when downstream actions related to private locations fail, the monitor is not deleted
Testing
I tested this PR by adding deliberate errors, such as reference issues, to the
synthetics_private_location
file, including thedeleteMonitor
,createMonitor
, andeditMonitor
code paths.createMonitor
codedeleteMonitor
code.Checklist
Delete any items that are not applicable to this PR.