-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] Private locations design feedback #137034
Conversation
Pinging @elastic/uptime (Team:uptime) |
Thanks Shahzad - I sent you this feedback in Slack which I think you already addressed in one of your last PRs. Reposting here for the record:
|
.../public/legacy_uptime/components/monitor_management/hooks/use_private_location_permission.ts
Outdated
Show resolved
Hide resolved
.../public/legacy_uptime/components/monitor_management/hooks/use_private_location_permission.ts
Outdated
Show resolved
Hide resolved
...tics/public/legacy_uptime/components/monitor_management/manage_locations/delete_location.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...tics/public/legacy_uptime/components/monitor_management/manage_locations/empty_locations.tsx
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
Related to elastic/uptime#475
Updated the design for private locations
Empty state in case there are no public/private locations, usually a case for non-cloud option
Add location form in flyout
Empty state in case of cloud
Locations list