Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Private locations design feedback #137034

Merged
merged 31 commits into from
Jul 26, 2022

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Jul 25, 2022

Summary

Related to elastic/uptime#475

Updated the design for private locations

Empty state in case there are no public/private locations, usually a case for non-cloud option

image

Add location form in flyout

image

Empty state in case of cloud

image

Locations list

image

@shahzad31 shahzad31 marked this pull request as ready for review July 25, 2022 11:09
@shahzad31 shahzad31 requested a review from a team as a code owner July 25, 2022 11:09
@shahzad31 shahzad31 added v8.4.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 25, 2022
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jul 25, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@hbharding
Copy link
Contributor

hbharding commented Jul 25, 2022

Thanks Shahzad - I sent you this feedback in Slack which I think you already addressed in one of your last PRs. Reposting here for the record:

  • “manage private locations” should be just “private locations”, both in the header link and the flyout title
  • The footer on the empty prompt is a little different than my design. It's fine, but can you make the text appear on a single line, and get rid of the bold text on “for more information”
  • On the monitor mgmt empty prompt for on-prem users, add "In order to create a monitor, you will need to add a location first." to the beginning of the text. Full text should read:

In order to create a monitor, you will need to add a location first. Private locations allow you to run monitors from your own premises. They require an Elastic agent and Agent policy which you can control and maintain via Fleet.

@dominiqueclarke dominiqueclarke self-requested a review July 25, 2022 18:50
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please address the small content pieces before merging, including this one on the enable page.

Screen Shot 2022-07-25 at 3 11 12 PM

Also, it's not necessary to show the whole Add Location empty prompt when the user does not have proper permissions
Screen Shot 2022-07-25 at 3 28 34 PM

@dominiqueclarke dominiqueclarke self-requested a review July 26, 2022 14:52
@dominiqueclarke
Copy link
Contributor

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #11 / ObservabilityApp Observability Rule Details page Page components maps correctly the rule type with the human readable rule type

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
synthetics 918 923 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 908.8KB 910.7KB +1.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke merged commit 9058f26 into elastic:main Jul 26, 2022
@dominiqueclarke dominiqueclarke deleted the private-node-design branch July 26, 2022 18:04
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants