Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Fix styling issues #135406

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Conversation

flash1293
Copy link
Contributor

This PR fixes some small styling issues introduced by the latest EUI update:
Screenshot 2022-06-29 at 12 18 32
Screenshot 2022-06-29 at 12 18 25
Screenshot 2022-06-29 at 12 17 36
Screenshot 2022-06-29 at 12 17 32

There is another issue with panels not having a border, but those should be fixed on EUI side: elastic/eui#6009

@flash1293 flash1293 added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens backport:skip This commit does not require backporting v8.4.0 labels Jun 29, 2022
@flash1293
Copy link
Contributor Author

The problem was caused by EuiText not adding another div element but instead adding its styling rules to the children - in some situations we relied on the element structure. This PR is adding back the div wrappers where they are needed

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.2MB 1.2MB +52.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
charts 46.2KB 46.2KB +23.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review June 29, 2022 11:27
@flash1293 flash1293 requested a review from a team as a code owner June 29, 2022 11:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! I tested it locally in Chrome and now both cases look fine!

@flash1293 flash1293 merged commit b590240 into elastic:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants