Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiPanel] Emotion styles not applied when rendering as button #6009

Closed
flash1293 opened this issue Jun 29, 2022 · 3 comments · Fixed by #6010
Closed

[EuiPanel] Emotion styles not applied when rendering as button #6009

flash1293 opened this issue Jun 29, 2022 · 3 comments · Fixed by #6010
Assignees

Comments

@flash1293
Copy link
Contributor

The panel component does not apply the emotion styles if it's rendering as button component:

styles passed in: https://github.com/elastic/eui/blob/main/src/components/panel/panel.tsx#L154

styles not passed in: https://github.com/elastic/eui/blob/main/src/components/panel/panel.tsx#L142

This is affecting at least these two places in Kibana:

Before:
Screenshot 2022-06-29 at 11 58 20
Screenshot 2022-06-29 at 11 58 06

After:
Screenshot 2022-06-29 at 11 58 03
Screenshot 2022-06-29 at 11 58 18

FYI @chandlerprall it would be great if this could be fixed for 8.4

@cchaos
Copy link
Contributor

cchaos commented Jun 29, 2022

@flash1293 Are you sure the styles aren't being passed or is it a specifically/ cascade issue? Can you check the rendered styles?

@cchaos
Copy link
Contributor

cchaos commented Jun 29, 2022

Nevermind, I see @miukimiu found and fixed the issue already.

@flash1293
Copy link
Contributor Author

Yeah, they are not passed (nothing is in the DOM)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants