Improve accessibility of visualizations #13507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 15, 2017 10:02
The way tooltips are currently implemented we unfortunately cannot use the tooltip for the aria-describedby. This is another issue to solve.
timroes
added
Project:Accessibility
Feature:Visualizations
timroes
requested review from
aphelionz,
cjcenizal,
thomasneirynck and
ppisljar
aphelionz
suggested changes
Aug 15, 2017
| @@ -48,6 +48,7 @@ <h2 class="kuiSubTitle kuiVerticalRhythm"> | |||
| ng-href="{{ getVisTypeUrl(type) }}" | |||
| tooltip="{{ getVisTypeTooltip(type) }}" | |||
| tooltip-placement="{{ getVisTypeTooltipPosition($parent.$index) }}" | |||
| aria-describedby="visDescription_{{::type.name}}" | |||
There was a problem hiding this comment.
Another dev wrote a function to normalize camelCase and other delimited text as screen readable. Might this be of use here?
There was a problem hiding this comment.
Good point. The name actually is kind of the id of the visualization and will be stored in the saved object to identify it. But honestly I am not sure what our restrictions are on this id currently, so I will check this up. Do you know by chance, where to find that function? :D
There was a problem hiding this comment.
I think @Bargs worked on it?
There was a problem hiding this comment.
Hmmm doesn't ring a bell for me
There was a problem hiding this comment.
Replaced it now with _.camelCase which should be fine for now. Care for another review? :)
timroes
added a commit
that referenced
this pull request
Aug 18, 2017
* Fix markdown vis settings labels * Fix contrast ratio of markdown blockquotes, #12491 * Fix fontsize of blockquotes in markdown, #12904 * Add vis type description for screen reader, fix #12887 The way tooltips are currently implemented we unfortunately cannot use the tooltip for the aria-describedby. This is another issue to solve. * Make main nav a11y when collapsed * Camel case the vistype id used in HTML
timroes
added a commit
that referenced
this pull request
Aug 18, 2017
* Fix markdown vis settings labels * Fix contrast ratio of markdown blockquotes, #12491 * Fix fontsize of blockquotes in markdown, #12904 * Add vis type description for screen reader, fix #12887 The way tooltips are currently implemented we unfortunately cannot use the tooltip for the aria-describedby. This is another issue to solve. * Make main nav a11y when collapsed * Camel case the vistype id used in HTML
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the accessibility of some visualization features.