-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve accessibility of visualizations (#13507)
* Fix markdown vis settings labels * Fix contrast ratio of markdown blockquotes, #12491 * Fix fontsize of blockquotes in markdown, #12904 * Add vis type description for screen reader, fix #12887 The way tooltips are currently implemented we unfortunately cannot use the tooltip for the aria-describedby. This is another issue to solve. * Make main nav a11y when collapsed * Camel case the vistype id used in HTML
- Loading branch information
Showing
7 changed files
with
22 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
src/core_plugins/markdown_vis/public/markdown_vis_params.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,15 @@ | ||
<div class="markdown-vis-options form-group"> | ||
<div> | ||
<label>Markdown</label> | ||
<label for="markdownVisInput">Markdown</label> | ||
<small class="pull-right"><a target="_window" href="https://help.github.com/articles/github-flavored-markdown/">Help <i aria-hidden="true" class="fa fa-link"></i></a></small> | ||
</div> | ||
<div class="kuiSideBarFormRow"> | ||
<label class="kuiSideBarFormRow__label"> | ||
<label class="kuiSideBarFormRow__label" for="markdownVisFontSize"> | ||
Font Size (<span ng-bind="vis.params.fontSize"></span>pt) | ||
</label> | ||
<div class="kuiSideBarFormRow__control"> | ||
<input type="range" ng-model="vis.params.fontSize" class="form-control" min="8" max="36" /> | ||
<input id="markdownVisFontSize" type="range" ng-model="vis.params.fontSize" class="form-control" min="8" max="36" /> | ||
</div> | ||
</div> | ||
<textarea ng-model="vis.params.markdown" class="form-control" rows="20"></textarea> | ||
<textarea id="markdownVisInput" ng-model="vis.params.markdown" class="form-control" rows="20"></textarea> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters