Improve accessibility of the discover app #13498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
changed the title
Until now the button was just empty, but could still be focused via keyboard. This is bad accessibility, so the sort button is now removed completelyw hen the column isn't sortable.
|
Backports:
|
timroes
added a commit
that referenced
this pull request
Aug 15, 2017
* Add sectioning to discover app, fix #12633 * Set unique page title for discover app, fix #12641 * Remove sort button if column isn't sortable Until now the button was just empty, but could still be focused via keyboard. This is bad accessibility, so the sort button is now removed completelyw hen the column isn't sortable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<section>element as discussed in Accessibility: Use <section> tags to delineate major areas in the discovery interface #12633 to structure the discover app for accessibility.Since most of the changes in one file come through reindentation I would recommend, ignoring whitespace when reviewing, by adding ?w=1.
Fix #12633, Fix #12641