Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Discussion required around how Discovery needs unique page title #12641

Closed
aphelionz opened this issue Jul 1, 2017 · 2 comments
Labels
bug Fixes for quality problems that affect the customer experience Project:Accessibility Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@aphelionz
Copy link
Contributor

The discovery interface, like all the other pages, needs a unique page title. It can be something as simple as 'Kibana Discovery" but it can also be something more contextual. Let's discuss!

@aphelionz aphelionz added Project:Accessibility Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. :Discovery labels Jul 1, 2017
@timroes
Copy link
Contributor

timroes commented Jul 6, 2017

I think it would be nice if the context of discover would be clear if you use multiple tabs open at the same time. Unfortunately the differences between the tabs will most likely be queries and filters. I don't think that it would make much sense to put this potentially very long texts into the title.

I think the only thing that might not totally explode in the title might be the current index pattern. The questions is: is this really a relevant use-case, that people often have multiple tabs open with the index pattern be what differentiate these tabs. Maybe someone has more insights then me, but it sounds a bit like a contrived use-case to me.

So I guess "Kibana Discover" might be the most reasonable title for now?

@cjcenizal
Copy link
Contributor

I think we can use the "Saved search" object's name as a differentiator between tabs. So if you haven't saved your search, we can default to "Kibana Discover", and if you have saved your search, we can default to "Kibana Discover: ${name of saved search object}". Thoughts?

@tbragin tbragin added the bug Fixes for quality problems that affect the customer experience label Jul 28, 2017
timroes pushed a commit to timroes/kibana that referenced this issue Aug 14, 2017
timroes added a commit that referenced this issue Aug 15, 2017
* Add sectioning to discover app, fix #12633

* Set unique page title for discover app, fix #12641

* Remove sort button if column isn't sortable

Until now the button was just empty, but could still be focused via
keyboard. This is bad accessibility, so the sort button is now removed
completelyw hen the column isn't sortable.
timroes added a commit that referenced this issue Aug 15, 2017
* Add sectioning to discover app, fix #12633

* Set unique page title for discover app, fix #12641

* Remove sort button if column isn't sortable

Until now the button was just empty, but could still be focused via
keyboard. This is bad accessibility, so the sort button is now removed
completelyw hen the column isn't sortable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Project:Accessibility Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

No branches or pull requests

4 participants