-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility: Discussion required around how Discovery needs unique page title #12641
Comments
I think it would be nice if the context of discover would be clear if you use multiple tabs open at the same time. Unfortunately the differences between the tabs will most likely be queries and filters. I don't think that it would make much sense to put this potentially very long texts into the title. I think the only thing that might not totally explode in the title might be the current index pattern. The questions is: is this really a relevant use-case, that people often have multiple tabs open with the index pattern be what differentiate these tabs. Maybe someone has more insights then me, but it sounds a bit like a contrived use-case to me. So I guess "Kibana Discover" might be the most reasonable title for now? |
I think we can use the "Saved search" object's name as a differentiator between tabs. So if you haven't saved your search, we can default to "Kibana Discover", and if you have saved your search, we can default to "Kibana Discover: ${name of saved search object}". Thoughts? |
* Add sectioning to discover app, fix #12633 * Set unique page title for discover app, fix #12641 * Remove sort button if column isn't sortable Until now the button was just empty, but could still be focused via keyboard. This is bad accessibility, so the sort button is now removed completelyw hen the column isn't sortable.
* Add sectioning to discover app, fix #12633 * Set unique page title for discover app, fix #12641 * Remove sort button if column isn't sortable Until now the button was just empty, but could still be focused via keyboard. This is bad accessibility, so the sort button is now removed completelyw hen the column isn't sortable.
The discovery interface, like all the other pages, needs a unique page title. It can be something as simple as 'Kibana Discovery" but it can also be something more contextual. Let's discuss!
The text was updated successfully, but these errors were encountered: