[Fleet] Remove confirm enrollment & confirm incoming data steps for standalone first integration flow #134474
Conversation
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
hop-dev
added
v8.3.0
v8.4.0
release_note:skip
...ns/fleet/public/components/agent_enrollment_flyout/steps/configure_standalone_agent_step.tsx
Show resolved
Hide resolved
| iconType="download" | ||
| onClick={() => { | ||
| if (onCopy) onCopy(); | ||
| window.location.href = downloadLink; |
There was a problem hiding this comment.
Can we put this in the href property of the component instead?
There was a problem hiding this comment.
Instead of removing confirm incoming data for standalone agents, we should keep it around. Currently the incoming data API requires specific enrolled agent IDs, but since we assume this to be the first agent the user adds, maybe we don't need exact IDs.
Could this requirement be removed from the API completely, or maybe the API can take a parameter to exclude ID for standalone case? My preference is the latter since we'll probably have to add it back in a future phase of this effort.
|
@jen-huang @kpollich I took a look on how to add back Incoming data to standalone and I have some concerns on how we should do it or if we should do it, (is seems to me that in standalone it’s okay to have less reporting feature in the UI and some limitations but it’s personal opinion here) if we really want to do it I see two way to do this:
In both scenario it seems a not trivial task that probably need to be more specified. |
…onfirm-data-for-standalone-agent
|
After discussing with @jen-huang and @kpollich it seems complicated to get preview data for standalone agents, I try to bring back the confirming data step with a static copy but I would love to have your thoughts on that @dborodyansky demo.mov |
|
@nchaulet, Looks like a reasonable trade off. Thank you. |
|
@elasticmachine merge upstream |
|
Looks good to me 👍 Thanks for this @nchaulet |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @hop-dev |
hop-dev
dismissed
jen-huang’s stale review
Jen is on leave and the comments have been addressed and re-reviewed by other Devs
…tandalone first integration flow (#134474) * remove data and agent confirmation steps from standalone flow * bonus: downloading policy should set step as complete * Bring confirm incoming data step for standalone agent Co-authored-by: Nicolas Chaulet <[email protected]> Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit e3aa999)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…tandalone first integration flow (#134474) (#134733) * remove data and agent confirmation steps from standalone flow * bonus: downloading policy should set step as complete * Bring confirm incoming data step for standalone agent Co-authored-by: Nicolas Chaulet <[email protected]> Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit e3aa999) Co-authored-by: Mark Hopkin <[email protected]>
Summary
Resolves #134337
The confirm enrollment and confirm incoming data steps don't work for standlone agents (this worked in dev as I had hacked the agent confirmation to allow me to move through the steps quickly 🤦 )
I do think we should look at adding this back in the future, I have created an issue for this #134476
Demo
reduced_standalone_flow.mp4