Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add open API specification for find connector #133840

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jun 7, 2022

Summary

Relates to #133345

This PR copies the layout used in https://github.com/elastic/kibana/tree/main/x-pack/plugins/fleet/common/openapi to model the following APIs:

https://www.elastic.co/guide/en/kibana/master/cases-api-find-connectors.html

It also adds a "summary" property for each operation, since that enables us to separate the short summary text from the longer description.

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs Feature:Cases Cases feature auto-backport Deprecated - use backport:version if exact versions are needed v8.4.0 v8.3.1 labels Jun 7, 2022
@lcawl lcawl changed the title Find connector Add open API specification for find connector Jun 7, 2022
@lcawl lcawl marked this pull request as ready for review June 8, 2022 02:14
@lcawl lcawl requested a review from a team as a code owner June 8, 2022 02:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@lcawl lcawl requested a review from a team June 8, 2022 02:14
Copy link
Contributor

@jonathan-buttner jonathan-buttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, didn't realize we had added the openapi support. Is there a way to view a example rendering of the docs from the changes in PRs?

@@ -31,7 +31,8 @@
"paths": {
"/api/cases": {
"post": {
"description": "Creates a case. You must have all privileges for the **Cases** feature in the **Management**, **Observability**, or **Security** section of the Kibana feature privileges, depending on the owner of the case you're creating.\n",
"summary": "Creates a case.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, are these auto generated by the paths yaml files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lcawl
Copy link
Contributor Author

lcawl commented Jun 14, 2022

Is there a way to view a example rendering of the docs from the changes in PRs?

The goal is to ultimately render them in the new documentation system, but for now the simplest method is to import it in a tool like SwaggerHub

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 14, 2022

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit that referenced this pull request Jun 14, 2022
kibanamachine added a commit that referenced this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed docs Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.3.1 v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants