-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add open API specification for find connector #133840
Conversation
Pinging @elastic/response-ops (Team:ResponseOps) |
Pinging @elastic/response-ops-cases (Feature:Cases) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, didn't realize we had added the openapi support. Is there a way to view a example rendering of the docs from the changes in PRs?
@@ -31,7 +31,8 @@ | |||
"paths": { | |||
"/api/cases": { | |||
"post": { | |||
"description": "Creates a case. You must have all privileges for the **Cases** feature in the **Management**, **Observability**, or **Security** section of the Kibana feature privileges, depending on the owner of the case you're creating.\n", | |||
"summary": "Creates a case.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, are these auto generated by the paths
yaml files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, they're generated using the npx commands in https://github.com/elastic/kibana/blob/main/x-pack/plugins/cases/docs/openapi/README.md
The goal is to ultimately render them in the new documentation system, but for now the simplest method is to import it in a tool like SwaggerHub |
💛 Build succeeded, but was flakyFailed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit 4eda70e)
(cherry picked from commit 4eda70e) Co-authored-by: Lisa Cawley <[email protected]>
Summary
Relates to #133345
This PR copies the layout used in https://github.com/elastic/kibana/tree/main/x-pack/plugins/fleet/common/openapi to model the following APIs:
https://www.elastic.co/guide/en/kibana/master/cases-api-find-connectors.html
It also adds a "summary" property for each operation, since that enables us to separate the short summary text from the longer description.