-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds OpenAPI specs for case comment endpoints #133400
Conversation
cc7efff
to
d3d4212
Compare
Pinging @elastic/response-ops (Team:ResponseOps) |
Pinging @elastic/response-ops-cases (Feature:Cases) |
x-pack/plugins/cases/docs/openapi/paths/api@cases@{caseid}@comments@{commentid}.yaml
Outdated
Show resolved
Hide resolved
x-pack/plugins/cases/docs/openapi/paths/api@cases@{caseid}@comments@{commentid}.yaml
Outdated
Show resolved
Hide resolved
x-pack/plugins/cases/docs/openapi/paths/api@cases@{caseid}@comments@{commentid}.yaml
Outdated
Show resolved
Hide resolved
...ck/plugins/cases/docs/openapi/paths/s@{spaceid}@api@cases@{caseid}@comments@{commentid}.yaml
Outdated
Show resolved
Hide resolved
...ck/plugins/cases/docs/openapi/paths/s@{spaceid}@api@cases@{caseid}@comments@{commentid}.yaml
Outdated
Show resolved
Hide resolved
...ck/plugins/cases/docs/openapi/paths/s@{spaceid}@api@cases@{caseid}@comments@{commentid}.yaml
Outdated
Show resolved
Hide resolved
x-pack/plugins/cases/docs/openapi/paths/api@cases@{caseid}@comments.yaml
Show resolved
Hide resolved
Co-authored-by: Lisa Cawley <[email protected]>
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added more summary fields and updated the text in the docs to reflect that you're adding/updating/deleting alerts or comments in the case. IMO it's ready now for technical review
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Co-authored-by: Lisa Cawley <[email protected]> (cherry picked from commit b05f8c1)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Co-authored-by: Lisa Cawley <[email protected]>
Co-authored-by: Lisa Cawley <[email protected]> (cherry picked from commit b05f8c1) Co-authored-by: István Zoltán Szabó <[email protected]>
Summary
This PR copies the layout used in https://github.com/elastic/kibana/tree/main/x-pack/plugins/fleet/common/openapi to model the following APIs:
It also removes the pop culture references, per #132473
It also clarifies the introduction for these APIs, to make it clear that you're adding/deleting/updating either a comment or an alert in the case.
Preview