[Fleet] Fix maintenance options for rolling upgrades #133369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
bug
|
Pinging @elastic/fleet (Team:Fleet) |
nchaulet
force-pushed
the
fix-133113-maintenance-window-options
branch
from
dbd9511 to
c130aac
Compare
juliaElastic
approved these changes
Jun 2, 2022
💛 Build succeeded, but was flakyFailed CI StepsTest Failures
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @nchaulet |
kibanamachine
pushed a commit
that referenced
this pull request
Jun 2, 2022
(cherry picked from commit eaca3c7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 2, 2022
(cherry picked from commit eaca3c7) Co-authored-by: Nicolas Chaulet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #133113
Fix available maintenance options for rolling upgrade:
Immediatlyshould be available even for more than 10 agentsImmediatlyshould be the default for <= 10 agents1 hourshould be the default for > 10 agentsI added some unit test to validate the default value depending on the agent count.