[Agent Upgrade]: Under Maintenance window available Immediately option is not displaying for bulk agent upgrade when agent is <=10.

[ghost]

Describe the bug:
Under Maintenance window available Immediately option is not displaying for bulk agent upgrade when agent is <=10 agent.

Build Details:
VERSION: 8.3.0-SNAPSHOT
COMMIT: c993ff2
BUILD: 53035
ARTIFACT LINK: https://snapshots.elastic.co/8.3.0-a497a6ef/summary-8.3.0-SNAPSHOT.html

Preconditions:

1. Elastic 8.3.0-SNAPSHOT environment should be deployed.

Steps to Reproduce:

1. Navigate to the Fleet tab under Management.
2. Now, under Agents tab select the Agents which are available for upgrade. (Agents should be less then <=10)
3. Click on Action button and select the upgrade version and upgrade Maintenance window available for the upgrade.
4. Observe that under Maintenance window available Immediately option is not displaying for bulk agent upgrade when agent is <=10 agent.

Expected Result:
Under Maintenance window available Immediately option should display for bulk agent upgrade when agent is <=10 agent.

What's working:
Previously Immediately option was displaying for bulk agent upgrade if agent is <=10.

Screenshot:

Refrenece ticket:
#132421

[elasticmachine]

Pinging @elastic/fleet (Team:Fleet)

[ghost]

@manishgupta-qasource Please review.

[manishgupta-qasource]

Secondary review for this ticket is Done

[jen-huang]

@nchaulet @criamico Could you clarify if this is expected behavior?

[nchaulet]

Re-reading the slack discussion where we decided to add Immediatly, I think it should be available even when we have more than 10 agents, but it should be the default when we have less than 10 agents.

[criamico]

@nchaulet I think that the reason why we decided to have it available only under 10 agents was to avoid that the user could use it when trying to update a large number of agents. I would still keep it hidden under a certain threshold for this reason, but it should definitely be there if <=10 agents.

[nchaulet]

@nchaulet I think that the reason why we decided to have it available only under 10 agents was to avoid that the user could use it when trying to update a large number of agents. I would still keep it hidden under a certain threshold for this reason, but it should definitely be there if <=10 agents.

From the slack discussion we had in the fleet channel it seems we did not talk about hiding this, but it's not clear :), I think it make sense to allow user to do it immediately even with more than 10 agents, but immediately should not be the default in this case @nimarezainia @ph what do you think?

[jen-huang]

@criamico @nchaulet I believe this bug report is that this option is not showing even when agent count is <= 10. It sounds like we expect the Immediate option to be present for a small amount of agents, so could one of you try to replicate this isue?

[nchaulet]

@jen-huang I just tested and the option is available for agents <= 10 we just need to decide if that option should be available for more agents

[jen-huang]

@nchaulet So this bug is invalid? Did you get to test on Cloud?

[nimarezainia]

@nchaulet the decision was to set it to "immediately" as the default when the agent count is less than 10. We never discussed forcing that by hiding the immediately option. But I think by hiding it we are saying it is enforced.

Could we at least show the option? because the way it is right now for <10 agents we are asking the user to choose a window of time to do it in, which is wrong.

Let's do this:

1. When agent =< 10 : default to immediately in the drop down. User can choose if they want a window
2. When agent > 10 : default to 1hr in the drop down. User can choose if they want it immediately or a bigger window

question is whether we have this flexibility in the drop down.

(fyi @joshdover )

[nchaulet]

@nchaulet So this bug is invalid? Did you get to test on Cloud?

I was finally able to reproduce it by selecting all agents, and not individually some agents. I am going to work on this:

• fixing the bug that should set Immediately as the default for less than 10 agents
• showing Immediately option for agent > 10

[ghost]

Hi @nchaulet
We have validated this issue on the latest 8.3.0-SNAPSHOT build and observed that the issue is fixed. Please find below the testing details:

• Under Maintenance window available Immediately option is displaying for bulk agent upgrade when agent is <=10 agent.

Screen-Recording:

Agents.-.Fleet.-.Elastic.-.Google.Chrome.2022-06-08.11-43-48.mp4

Build Details:
VERSION: 8.3.0-SNAPSHOT
COMMIT: 6ef4570
BUILD: 53295
ARTIFACT LINK: https://snapshots.elastic.co/8.3.0-b94e381c/summary-8.3.0-SNAPSHOT.html

Hence, marking this issue as QA Validated.

Thanks!