-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Content management] Add "Last updated" metadata to TableListView #132321
[Content management] Add "Last updated" metadata to TableListView #132321
Conversation
This reverts commit a14161805945fbe9538827c5bc7bff8919d55eab.
69d8be7
to
88c203d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Discovery changes LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great for Dashboard! Filed an issue to make use of this in Canvas as well, since we are currently implementing something similar without using the TableListView
component. LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VisEditors changes LGTM
@nreese I got the same failure on a different build. Any idea why this test is now failing with the changes made here? |
@KOTungseth Can you check this UI copy? Mainly the new elements are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kibana-gis changes LGTM
code review
See #132368. A change in the elasticsearch snapshot changed the order of the geometry getting returned. This caused these tests to fail. They have been skipped in main until we can get a PR out to update the tests. |
@elasticmachine merge upstream |
Perfect thanks @nreese 👍 |
Let's stay with
For consistency, let's change this tooltip to |
@cchaos If we think it can be confusing, we could add a tooltip when the user hovers to explain what we mean by "Last updated" |
Thanks for the review @KOTungseth ! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement, thanks @sebelga!
@teresaalvarezsoler I had a similar tooltip idea. We'll need to workshop the language on that for a bit, so I won't hold up this PR and we can add later.
💛 Build succeeded, but was flakyFailed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
In this PR I've updated the implementation of the
<TableListView />
component (exposed by thekibana_react
plugin) to render a "Last updated" column if the items of the table contain theupdatedAt
metadata.I have then updated the consuming apps to include the
updatedAt
from their saved objects when fetching the table items.Note on implementation
I've decided to render relative date ("a minute ago", "yesterday", "2 days ago") for up to 7 days ago. If an object has been updated more than 7 days ago we then render this format:
"May 17, 2022"
When there is no data for a specific saved object then a dash
"-"
is displayed with a tooltipHow to test
Release note
The list view for Dashboards, Visualizations, Maps and Graph has a new "Last updated" column to easily access content that has been recently modified.
Updated apps
Fixes #132134