Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finding flyout changes #132115

Merged
merged 18 commits into from
May 15, 2022
Merged

Finding flyout changes #132115

merged 18 commits into from
May 15, 2022

Conversation

JordanSh
Copy link
Contributor

@JordanSh JordanSh commented May 12, 2022 •
edited
Loading

Summary

Updates to the findings flyout

  • The first tab now displays all primary information: rule details, evaluation time, remediation, and evidence
  • General tab renamed to Overview to better represent the above change
  • Using collapsable sections
  • Remediation tab removed
  • Added Rule tab to display full rule information instead of general
  • Name and Description fields are now displayed first
Screen.Recording.2022-05-12.at.12.33.13.mov

@JordanSh JordanSh added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Cloud Security Cloud Security team related v8.3.0 labels May 15, 2022
@JordanSh JordanSh self-assigned this May 15, 2022
@JordanSh JordanSh marked this pull request as ready for review May 15, 2022 13:09
@JordanSh JordanSh requested a review from a team as a code owner May 15, 2022 13:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security Posture)

@JordanSh JordanSh requested a review from kfirpeled May 15, 2022 13:09
kfirpeled
kfirpeled requested changes May 15, 2022
View reviewed changes
x-pack/plugins/cloud_security_posture/public/pages/findings/findings_flyout/overview_tab.tsx Outdated
() => [
{
initialIsOpen: true,
title: 'Details',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing use of i18n framework

@JordanSh JordanSh requested a review from kfirpeled May 15, 2022 13:19
kfirpeled
kfirpeled approved these changes May 15, 2022
View reviewed changes
Copy link
Contributor

@kfirpeled kfirpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JordanSh JordanSh enabled auto-merge (squash) May 15, 2022 15:47
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudSecurityPosture 183 185 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 180.7KB 181.9KB +1.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @JordanSh

@JordanSh JordanSh merged commit 059f09d into elastic:main May 15, 2022
Bamieh pushed a commit to Bamieh/kibana that referenced this pull request May 16, 2022
@JordanSh @Bamieh
Finding flyout changes (elastic#132115)
4f6faac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfirpeled kfirpeled kfirpeled approved these changes

Assignees

@JordanSh JordanSh

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JordanSh @elasticmachine @kibana-ci @kfirpeled