forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Finding flyout changes (elastic#132115)
- Loading branch information
Showing
6 changed files
with
237 additions
and
94 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
142 changes: 142 additions & 0 deletions
142
x-pack/plugins/cloud_security_posture/public/pages/findings/findings_flyout/overview_tab.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,142 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { | ||
EuiAccordion, | ||
EuiDescriptionList, | ||
EuiFlexGroup, | ||
EuiFlexItem, | ||
EuiIcon, | ||
EuiPanel, | ||
EuiSpacer, | ||
EuiText, | ||
} from '@elastic/eui'; | ||
import React, { useMemo } from 'react'; | ||
import moment from 'moment'; | ||
import type { EuiDescriptionListProps, EuiAccordionProps } from '@elastic/eui'; | ||
import cisLogoIcon from '../../../assets/icons/cis_logo.svg'; | ||
import k8sLogoIcon from '../../../assets/icons/k8s_logo.svg'; | ||
import * as TEXT from '../translations'; | ||
import { CspFinding } from '../types'; | ||
import { CodeBlock, Markdown } from './findings_flyout'; | ||
|
||
type Accordion = Pick<EuiAccordionProps, 'title' | 'id' | 'initialIsOpen'> & | ||
Pick<EuiDescriptionListProps, 'listItems'>; | ||
|
||
const getDetailsList = (data: CspFinding) => [ | ||
{ | ||
title: TEXT.EVALUATED_AT, | ||
description: moment(data['@timestamp']).format('MMMM D, YYYY @ HH:mm:ss.SSS'), | ||
}, | ||
{ | ||
title: TEXT.RESOURCE_NAME, | ||
description: data.resource.name, | ||
}, | ||
{ | ||
title: TEXT.RULE_NAME, | ||
description: data.rule.name, | ||
}, | ||
{ | ||
title: TEXT.FRAMEWORK_SOURCES, | ||
description: ( | ||
<EuiFlexGroup gutterSize="s"> | ||
<EuiFlexItem grow={false}> | ||
<EuiIcon type={cisLogoIcon} size="xxl" /> | ||
</EuiFlexItem> | ||
<EuiFlexItem grow={false}> | ||
<EuiIcon type={k8sLogoIcon} size="xxl" /> | ||
</EuiFlexItem> | ||
</EuiFlexGroup> | ||
), | ||
}, | ||
{ | ||
title: TEXT.CIS_SECTION, | ||
description: data.rule.section, | ||
}, | ||
]; | ||
|
||
const getRemediationList = ({ rule }: CspFinding) => [ | ||
{ | ||
title: '', | ||
description: <Markdown>{rule.remediation}</Markdown>, | ||
}, | ||
{ | ||
title: TEXT.IMPACT, | ||
description: <Markdown>{rule.impact}</Markdown>, | ||
}, | ||
{ | ||
title: TEXT.DEFAULT_VALUE, | ||
description: <Markdown>{rule.default_value}</Markdown>, | ||
}, | ||
{ | ||
title: TEXT.RATIONALE, | ||
description: <Markdown>{rule.rationale}</Markdown>, | ||
}, | ||
]; | ||
|
||
const getEvidenceList = ({ result }: CspFinding) => | ||
[ | ||
result.expected && { | ||
title: TEXT.EXPECTED, | ||
description: <CodeBlock>{JSON.stringify(result.expected, null, 2)}</CodeBlock>, | ||
}, | ||
{ | ||
title: TEXT.ACTUAL, | ||
description: <CodeBlock>{JSON.stringify(result.evidence, null, 2)}</CodeBlock>, | ||
}, | ||
].filter(Boolean) as EuiDescriptionListProps['listItems']; | ||
|
||
export const OverviewTab = ({ data }: { data: CspFinding }) => { | ||
const accordions: Accordion[] = useMemo( | ||
() => [ | ||
{ | ||
initialIsOpen: true, | ||
title: TEXT.DETAILS, | ||
id: 'detailsAccordion', | ||
listItems: getDetailsList(data), | ||
}, | ||
{ | ||
initialIsOpen: true, | ||
title: TEXT.REMEDIATION, | ||
id: 'remediationAccordion', | ||
listItems: getRemediationList(data), | ||
}, | ||
{ | ||
initialIsOpen: false, | ||
title: TEXT.EVIDENCE, | ||
id: 'evidenceAccordion', | ||
listItems: getEvidenceList(data), | ||
}, | ||
], | ||
[data] | ||
); | ||
|
||
return ( | ||
<> | ||
{accordions.map((accordion) => ( | ||
<React.Fragment key={accordion.id}> | ||
<EuiPanel hasShadow={false} hasBorder> | ||
<EuiAccordion | ||
id={accordion.id} | ||
buttonContent={ | ||
<EuiText> | ||
<strong>{accordion.title}</strong> | ||
</EuiText> | ||
} | ||
arrowDisplay="right" | ||
initialIsOpen={accordion.initialIsOpen} | ||
> | ||
<EuiSpacer size="m" /> | ||
<EuiDescriptionList listItems={accordion.listItems} /> | ||
</EuiAccordion> | ||
</EuiPanel> | ||
<EuiSpacer size="m" /> | ||
</React.Fragment> | ||
))} | ||
</> | ||
); | ||
}; |
63 changes: 63 additions & 0 deletions
63
x-pack/plugins/cloud_security_posture/public/pages/findings/findings_flyout/rule_tab.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { EuiDescriptionList, EuiFlexGroup, EuiFlexItem, EuiIcon } from '@elastic/eui'; | ||
import React from 'react'; | ||
import cisLogoIcon from '../../../assets/icons/cis_logo.svg'; | ||
import k8sLogoIcon from '../../../assets/icons/k8s_logo.svg'; | ||
import * as TEXT from '../translations'; | ||
import { CspFinding } from '../types'; | ||
import { Markdown } from './findings_flyout'; | ||
|
||
const getRuleList = ({ rule }: CspFinding) => [ | ||
{ | ||
title: TEXT.NAME, | ||
description: rule.name, | ||
}, | ||
{ | ||
title: TEXT.DESCRIPTION, | ||
description: <Markdown>{rule.description}</Markdown>, | ||
}, | ||
{ | ||
title: TEXT.FRAMEWORK_SOURCES, | ||
description: ( | ||
<EuiFlexGroup gutterSize="s"> | ||
<EuiFlexItem grow={false}> | ||
<EuiIcon type={cisLogoIcon} size="xxl" /> | ||
</EuiFlexItem> | ||
<EuiFlexItem grow={false}> | ||
<EuiIcon type={k8sLogoIcon} size="xxl" /> | ||
</EuiFlexItem> | ||
</EuiFlexGroup> | ||
), | ||
}, | ||
{ | ||
title: TEXT.CIS_SECTION, | ||
description: rule.section, | ||
}, | ||
{ | ||
title: TEXT.PROFILE_APPLICABILITY, | ||
description: <Markdown>{rule.profile_applicability}</Markdown>, | ||
}, | ||
{ | ||
title: TEXT.BENCHMARK, | ||
description: rule.benchmark.name, | ||
}, | ||
|
||
{ | ||
title: TEXT.AUDIT, | ||
description: <Markdown>{rule.audit}</Markdown>, | ||
}, | ||
{ | ||
title: TEXT.REFERENCES, | ||
description: <Markdown>{rule.references}</Markdown>, | ||
}, | ||
]; | ||
|
||
export const RuleTab = ({ data }: { data: CspFinding }) => ( | ||
<EuiDescriptionList listItems={getRuleList(data)} /> | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.