Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fix broken add fleet server button on policies page flyout #131840

Merged

Conversation

kpollich
Copy link
Member

@kpollich kpollich commented May 9, 2022

Summary

Fix "Add Fleet Server" button not doing anything when opening enrollment flyout during "Add Integration" flow.

Fixes #131706

Related follow-up tech debt issue: #131839

Screen Recording

Screen.Recording.2022-05-09.at.3.02.00.PM.mov

@kpollich kpollich added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0 labels May 9, 2022
@kpollich kpollich requested a review from a team as a code owner May 9, 2022 19:12
@kpollich kpollich self-assigned this May 9, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@juliaElastic
Copy link
Contributor

juliaElastic commented May 10, 2022

I tested locally from Add integration -> Add Elastic Agent to your hosts and I'm getting this error:

http://localhost:5620/app/integrations/detail/tomcat-1.4.0/policies?addAgentToPolicyId=b0c164d0-d053-11ec-b639-2b4762658454
image

@kpollich
Copy link
Member Author

I tested locally from Add integration -> Add Elastic Agent to your hosts and I'm getting this error

@juliaElastic - this is fixed in a48fae5. Error was caught by our Cypress tests too 🥳

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 620 621 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 704.2KB 704.4KB +179.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 90.4KB 90.9KB +562.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@kpollich kpollich merged commit 3ad48fe into elastic:main May 10, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 10, 2022
@kpollich kpollich deleted the 131706-fix-broken-fleet-server-flyout-button branch May 10, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0
Projects
None yet
5 participants