Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Remove duplicate instances of AgentEnrollmentFlyout #131839

Open
kpollich opened this issue May 9, 2022 · 1 comment
Open

[Fleet] Remove duplicate instances of AgentEnrollmentFlyout #131839

kpollich opened this issue May 9, 2022 · 1 comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture

Comments

@kpollich
Copy link
Member

kpollich commented May 9, 2022

In 8.3, we've pivoted the flyout implementation for the enrollment and Fleet Server flyouts to a "singleton" approach using React Context. We've got some leftover implementations where we're rendering duplicate instances of the AgentEnrollmentFlyout component that should be cleaned up and converted to using the new global context object found in hooks/flyout_context.tsx.
@kpollich kpollich added technical debt Improvement of the software architecture and operational architecture Team:Fleet Team label for Observability Data Collection Fleet team labels May 9, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kpollich kpollich mentioned this issue May 9, 2022
Merged
@kpollich kpollich mentioned this issue Sep 13, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kpollich @elasticmachine