Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workplace Search] Remove unused user filtering in groups #131316

Merged
merged 1 commit into from
May 2, 2022
Merged

[Workplace Search] Remove unused user filtering in groups #131316

merged 1 commit into from
May 2, 2022

Conversation

ioanatia
Copy link
Contributor

@ioanatia ioanatia commented May 2, 2022 •
edited
Loading

Summary

following up on #104734

removes unused logic for filtering groups by users

For maintainers

@ioanatia ioanatia added the v8.3.0 label May 2, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.5MB 1.5MB -1.0KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ioanatia ioanatia marked this pull request as ready for review May 2, 2022 12:38
@ioanatia ioanatia requested a review from a team May 2, 2022 12:38
@ioanatia ioanatia added technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes labels May 2, 2022
sphilipse
sphilipse approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@sphilipse sphilipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ioanatia ioanatia merged commit 7e5408b into elastic:main May 2, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 2, 2022
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
@ioanatia @kertal
Remove unused user filtering (elastic#131316)
7d01d94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphilipse sphilipse sphilipse approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch technical debt Improvement of the software architecture and operational architecture v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ioanatia @kibana-ci @sphilipse @rashmivkulkarni @kibanamachine