Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workplace Search] Remove groups user management and filter #104734

Conversation

scottybollinger
Copy link
Contributor

@scottybollinger scottybollinger commented Jul 7, 2021

relates to https://github.com/elastic/enterprise-search-team/issues/700

Summary

This PR fixes a bug that was introduced as a part of the User management feature. We can no longer manage users from the Groups view and, instead, need to route users to the Users and roles screen.

Mainly, this PR accomplishes 2 things:

  1. Removes the Users filter on the Groups page:

Before
gs-before

After
gs-after

  1. Removes the Groups user manager modal in favor of a link to Users and roles:

Before
g-before

After
g-after

Checklist

@scottybollinger scottybollinger added release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 7, 2021
@scottybollinger scottybollinger force-pushed the scottybollinger/users-groups-refactor branch from 8d6e918 to 36664b1 Compare July 7, 2021 18:22
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 1443 1441 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.1MB 2.1MB -3.8KB

History

  • 💔 Build #137001 failed 8d6e9189b3caf94085c7e74f868b12299f492cfe

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@scottybollinger scottybollinger marked this pull request as ready for review July 7, 2021 21:13
@scottybollinger scottybollinger requested a review from a team July 7, 2021 21:13
@scottybollinger scottybollinger merged commit 60a9eb9 into elastic:master Jul 8, 2021
@scottybollinger scottybollinger deleted the scottybollinger/users-groups-refactor branch July 8, 2021 13:43
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 8, 2021
…104734)

* Remove TableFilterUsersDropdown

* Update button to point to users and roles

* Remove modal and group users logic

* Remove route

* Remove i18n translations
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 8, 2021
…104734)

* Remove TableFilterUsersDropdown

* Update button to point to users and roles

* Remove modal and group users logic

* Remove route

* Remove i18n translations
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.14
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 8, 2021
…#104872)

* Remove TableFilterUsersDropdown

* Update button to point to users and roles

* Remove modal and group users logic

* Remove route

* Remove i18n translations

Co-authored-by: Scotty Bollinger <[email protected]>
kibanamachine added a commit that referenced this pull request Jul 8, 2021
…#104874)

* Remove TableFilterUsersDropdown

* Update button to point to users and roles

* Remove modal and group users logic

* Remove route

* Remove i18n translations

Co-authored-by: Scotty Bollinger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v7.14.0 v7.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants