-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workplace Search] Remove groups user management and filter #104734
Merged
scottybollinger
merged 5 commits into
elastic:master
from
scottybollinger:scottybollinger/users-groups-refactor
Jul 8, 2021
Merged
[Workplace Search] Remove groups user management and filter #104734
scottybollinger
merged 5 commits into
elastic:master
from
scottybollinger:scottybollinger/users-groups-refactor
Jul 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottybollinger
added
release_note:skip
Skip the PR/issue when compiling release notes
v7.14.0
auto-backport
Deprecated - use backport:version if exact versions are needed
v7.15.0
labels
Jul 7, 2021
scottybollinger
force-pushed
the
scottybollinger/users-groups-refactor
branch
from
July 7, 2021 18:22
8d6e918
to
36664b1
Compare
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
yakhinvadim
approved these changes
Jul 8, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 8, 2021
…104734) * Remove TableFilterUsersDropdown * Update button to point to users and roles * Remove modal and group users logic * Remove route * Remove i18n translations
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 8, 2021
…104734) * Remove TableFilterUsersDropdown * Update button to point to users and roles * Remove modal and group users logic * Remove route * Remove i18n translations
kibanamachine
added a commit
that referenced
this pull request
Jul 8, 2021
…#104872) * Remove TableFilterUsersDropdown * Update button to point to users and roles * Remove modal and group users logic * Remove route * Remove i18n translations Co-authored-by: Scotty Bollinger <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jul 8, 2021
…#104874) * Remove TableFilterUsersDropdown * Update button to point to users and roles * Remove modal and group users logic * Remove route * Remove i18n translations Co-authored-by: Scotty Bollinger <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
release_note:skip
Skip the PR/issue when compiling release notes
Team:EnterpriseSearch
v7.14.0
v7.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to https://github.com/elastic/enterprise-search-team/issues/700
Summary
This PR fixes a bug that was introduced as a part of the User management feature. We can no longer manage users from the Groups view and, instead, need to route users to the Users and roles screen.
Mainly, this PR accomplishes 2 things:
Before
After
Before
After
Checklist