-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] add monitor management docs link #130558
Merged
dominiqueclarke
merged 1 commit into
elastic:main
from
dominiqueclarke:fix/uptime-monitor-management-docs-link
Apr 19, 2022
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -75,7 +75,10 @@ export const EnablementEmptyState = ({ focusButton }: { focusButton: boolean }) | |||||
<EuiTitle size="xxs"> | ||||||
<h3>{LEARN_MORE_LABEL}</h3> | ||||||
</EuiTitle> | ||||||
<EuiLink href="#" target="_blank"> | ||||||
<EuiLink | ||||||
href="https://docs.google.com/document/d/1hkzFibu9LggPWXQqfbAd0mMlV75wCME7_BebXlEH-oI" | ||||||
target="_blank" | ||||||
> | ||||||
{DOCS_LABEL} | ||||||
</EuiLink> | ||||||
</> | ||||||
|
@@ -102,15 +105,15 @@ const MONITOR_MANAGEMENT_ENABLEMENT_MESSAGE = i18n.translate( | |||||
'xpack.uptime.monitorManagement.emptyState.enablement', | ||||||
{ | ||||||
defaultMessage: | ||||||
'Enable Monitor Management to run lightweight checks and real-browser monitors from hosted testing locations around the world. Enabling Monitor Management will generate an API key to allow the Synthetics Service to write back to your Elasticsearch cluster.', | ||||||
'Enable Monitor Management to run lightweight and real-browser monitors from hosted testing locations around the world. Enabling Monitor Management will generate an API key to allow the Synthetics Service to write back to your Elasticsearch cluster.', | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
@drewpost how is this? |
||||||
} | ||||||
); | ||||||
|
||||||
const MONITOR_MANAGEMENT_DISABLED_MESSAGE = i18n.translate( | ||||||
'xpack.uptime.monitorManagement.emptyState.enablement.disabledDescription', | ||||||
{ | ||||||
defaultMessage: | ||||||
'Monitor Management is currently disabled. Monitor Management allows you to run lightweight checks and real-browser monitors from hosted testing locations around the world. To enable Monitor Management, please contact an administrator.', | ||||||
'Monitor Management is currently disabled. Monitor Management allows you to run lightweight and real-browser monitors from hosted testing locations around the world. To enable Monitor Management, please contact an administrator.', | ||||||
} | ||||||
); | ||||||
|
||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The term "Synthetics Service" is new to me so I'm not sure exactly what it refers to, but that might be ok if it's made clear in the linked document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drewpost @paulb-elastic Have we thought about concrete terms for how we refer to the service that runs the tests on our hosted testing nodes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question... I've been referring to it as the
Synthetics Cloud Service
. @drewpost do you have something in mind?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guilty of sowing the seeds of confusion here. Internally we've called it synthetics service but as a part of the broader Synthetics product, this capability is "Global managed testing infrastructure"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have many places in docs where we use "Synthetics Service". I will be updated them all.