Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] add monitor management docs link #130558

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,10 @@ export const EnablementEmptyState = ({ focusButton }: { focusButton: boolean })
<EuiTitle size="xxs">
<h3>{LEARN_MORE_LABEL}</h3>
</EuiTitle>
<EuiLink href="#" target="_blank">
<EuiLink
href="https://docs.google.com/document/d/1hkzFibu9LggPWXQqfbAd0mMlV75wCME7_BebXlEH-oI"
target="_blank"
>
{DOCS_LABEL}
</EuiLink>
</>
Expand All @@ -102,15 +105,15 @@ const MONITOR_MANAGEMENT_ENABLEMENT_MESSAGE = i18n.translate(
'xpack.uptime.monitorManagement.emptyState.enablement',
{
defaultMessage:
'Enable Monitor Management to run lightweight checks and real-browser monitors from hosted testing locations around the world. Enabling Monitor Management will generate an API key to allow the Synthetics Service to write back to your Elasticsearch cluster.',
'Enable Monitor Management to run lightweight and real-browser monitors from hosted testing locations around the world. Enabling Monitor Management will generate an API key to allow the Synthetics Service to write back to your Elasticsearch cluster.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The term "Synthetics Service" is new to me so I'm not sure exactly what it refers to, but that might be ok if it's made clear in the linked document.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drewpost @paulb-elastic Have we thought about concrete terms for how we refer to the service that runs the tests on our hosted testing nodes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question... I've been referring to it as the Synthetics Cloud Service. @drewpost do you have something in mind?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guilty of sowing the seeds of confusion here. Internally we've called it synthetics service but as a part of the broader Synthetics product, this capability is "Global managed testing infrastructure"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have many places in docs where we use "Synthetics Service". I will be updated them all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Enable Monitor Management to run lightweight and real-browser monitors from hosted testing locations around the world. Enabling Monitor Management will generate an API key to allow the Synthetics Service to write back to your Elasticsearch cluster.',
'Enable Monitor Management to run lightweight and real-browser monitors from hosted testing locations around the world. Enabling Monitor Management will generate an API key to allow our global managed testing infrastructure to write back to your Elasticsearch cluster.',

@drewpost how is this?

}
);

const MONITOR_MANAGEMENT_DISABLED_MESSAGE = i18n.translate(
'xpack.uptime.monitorManagement.emptyState.enablement.disabledDescription',
{
defaultMessage:
'Monitor Management is currently disabled. Monitor Management allows you to run lightweight checks and real-browser monitors from hosted testing locations around the world. To enable Monitor Management, please contact an administrator.',
'Monitor Management is currently disabled. Monitor Management allows you to run lightweight and real-browser monitors from hosted testing locations around the world. To enable Monitor Management, please contact an administrator.',
}
);

Expand Down